Add SAML/OIDC comparison by David Chadwick #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlongley
reviewed
Oct 16, 2017
comparison.html
Outdated
| </p> | ||
|
|
||
| <p> | ||
| The FIM trust model is wrong as it requires the Identity Provider (IdP) |
There was a problem hiding this comment.
Let's strike "is wrong as it". It's a subjective value judgment that detracts from the point.
kimdhamilton
approved these changes
Oct 17, 2017
comparison.html
Outdated
| </section> | ||
|
|
||
| <section> | ||
| <h1>Comparison of Verificable Credentials with SAML and OIDC</h1> |
There was a problem hiding this comment.
small typo: "Verificable" -> "Verifiable"
dlongley
approved these changes
Oct 25, 2017
|
As a novice to SAML and OIDC I would have no idea that this was a comparison since they are referenced but not mentioned by name. Rather, this reads to me like one of the most compact explanations of why we are doing the VC work that I have ever read. I was surprised to find it a separate doc and not part of our spec. The text itself is wonderful and I am willing to accept it as-is to get something in place, but I do have the two concerns above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a comparison between SAML and OpenID Connect done by @David-Chadwick.