Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

working on #777 #785

Merged
merged 4 commits into from Aug 24, 2021
Merged

working on #777 #785

merged 4 commits into from Aug 24, 2021

Conversation

TallTed
Copy link
Member

@TallTed TallTed commented Jul 29, 2021 •
edited by pr-preview bot

tries to partially (diagram changes are also needed) fix #777, by uncoloring and adjusting the text

Preview | Diff

wyc and others added 2 commits July 13, 2021 16:59
@wyc @msporny
@davidlehn @brentzundel
Add PR review process for 2021 (#774)
1f574ef 
* Add PR review process for 2021.

* Avoid GitHub id auto-linking.

Co-authored-by: David I. Lehn <dil@lehn.org>

* Update README.md

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>
Co-authored-by: David I. Lehn <dil@lehn.org>
Co-authored-by: Brent Zundel <brent.zundel@gmail.com>
@TallTed
Update index.html
29a3e5e 
tries to partially (diagram changes are also needed) fix #777, by uncoloring and adjusting the text
@TallTed TallTed mentioned this pull request Jul 29, 2021
Closed
@kdenhartog
Copy link
Member

Thanks for the PR for this fix. Looks good to me, I'll include it in the round of updates for the CCG to review.

@kdenhartog kdenhartog added this to the V1.1 Completion milestone Jul 29, 2021
@kdenhartog kdenhartog added editorial Purely editorial changes to the specification. errata Erratum for a W3C Recommendation v1.1 labels Jul 29, 2021
@kdenhartog kdenhartog changed the base branch from main to v1.1 July 29, 2021 22:32
@kdenhartog
Copy link
Member

@TallTed I had to repoint this at v1.1 for the updates which brought that README.md update back in. Once we get the other PR through then that should get removed I believe.

TallTed
TallTed commented Aug 11, 2021
View reviewed changes
index.html Outdated Show resolved Hide resolved
TallTed
TallTed commented Aug 11, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
TallTed
TallTed commented Aug 11, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@TallTed
Apply suggestions from code review
e02dafe 
Cleaned up markdown tags, and added word missed previously
@TallTed
Copy link
Member Author

TallTed commented Aug 11, 2021

Sorry this blends index.html with README.md edits... I'm hoping that can be OK for this PR, but will create two new PRs if need be.

@iherman
Copy link
Member

iherman commented Aug 12, 2021

The issue was discussed in a meeting on 2021-08-11

  • no resolutions were taken
View the transcript

3.4. working on #777 (pr vc-data-model#785)

See github pull request #785.

Ted Thibodeau Jr.: this is self explanatory. Just did a bit of patch work. Changes readme and spec html

Wayne Chang: we will merge as soon as we hit the 14-day mark

Wayne Chang: sorry q?

Kyle Den Hartog: I'm going to take Ted's readme changes and merge them into main as well

Brent Zundel: +1 to kdenhartog

Manu Sporny: +1 to merge

@kdenhartog kdenhartog removed this from the V1.1 Completion milestone Aug 13, 2021
@kdenhartog
Copy link
Member

multiple positive reviews, feedback received and incorporated, merging

@kdenhartog kdenhartog merged commit a0f4863 into v1.1 Aug 24, 2021
@kdenhartog kdenhartog deleted the TallTed-figure7-figure8-text branch August 24, 2021 02:50
@kdenhartog kdenhartog mentioned this pull request Aug 30, 2021
Closed
This was referenced Nov 16, 2021
Merged
Closed
@kdenhartog
Copy link
Member

There is an Errata label for this on a linked issue, so removing the label from the PR. Also noting that this isn't currently on the V1.1 branch and investigation still needs to be done on what happened here.

@kdenhartog kdenhartog removed errata Erratum for a W3C Recommendation editorial Purely editorial changes to the specification. labels Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msporny msporny Awaiting requested review from msporny msporny is a code owner

@brentzundel brentzundel Awaiting requested review from brentzundel

@kdenhartog kdenhartog Awaiting requested review from kdenhartog

Assignees
No one assigned
Labels
merge after 14 days
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

all-but-illegible text style needs fix for humans
6 participants
@TallTed @kdenhartog @iherman @msporny @brentzundel @wyc