Credentials and Verifiable Credentials #808

David-Chadwick · 2021-08-30T10:25:41Z

This PR is text for issue #798

TallTed · 2021-08-30T19:28:37Z

index.html

 <a>Holders</a> assemble collections of <a>verifiable credentials</a> from
 different <a>issuers</a> into a single artifact, a
-<a>verifiable presentation</a>.
+<a>presentation</a>.


Suggested change

<a>Holders</a> assemble collections of <a>verifiable credentials</a> from

different <a>issuers</a> into a single artifact, a

<a>verifiable presentation</a>.

<a>presentation</a>.

<a>Holders</a> assemble collections of <a>credentials</a> and/or

<a>verifiable credentials</a> from different <a>issuers</a> into a single

artifact, a <a>presentation</a>.

@David-Chadwick -- Since you explicitly noted agreement elsewhere, and not here, I have to ask whether you agree or disagree with this edit, which is not properly highlighted by Github. To be clear, I changed --

collections of <a>verifiable credentials</a> from different

-- to --

collections of <a>credentials</a> and/or <a>verifiable credentials</a> from different

@David-Chadwick -- This change still appears not to have been made. Do you disagree with it?

@David-Chadwick -- Still waiting on this one. Other changes (from me and @msporny) have been applied during that wait.

What's wrong with this one?

I don't believe that holders assemble credentials into presentations, but only verifiable credentials, as per my original text

I do still await commitment of this suggestion, as well as @dlongley's suggestion below.

For future reference, silent disagreement with a change request, in apparent hopes it will disappear when the rest of a PR is merged, is rather passive-aggressive, and is not conducive to civil discourse. If a PR author disagrees with a change request to their PR, it is incumbent upon them to respond to that request, not by silently resolving the conversation (without committing the request), nor by silently ignoring it; the PR author is expected to engage in dialog with the change requester (and/or others in the relevant community, here being the VCWG and CCG) toward finding a mutually (or at least group) agreeable revision.

(@burnburn @brentzundel @msporny @dlongley -- As chairs and editors, please correct me if I'm wrong in my assertions above.)

Please read my earlier post in which I categorically stated "Ok I will accept all the proposed changes and update the PR." So your comment above is uncalled for since I neither ignored your changes nor suggested alternative ones. I have stated that I have accepted them. So please be patient and wait for the updated PR.

Please read my earlier post in which I categorically stated "Ok I will accept all the proposed changes and update the PR." So your comment above is uncalled for since I neither ignored your changes nor suggested alternative ones. I have stated that I have accepted them. So please be patient and wait for the updated PR.

I waited 8 days for response to one change. Which response I only received after directly asking for such multiple times and enlisting others to the same. Unlike the other change requests which were committed without such delay.

I look forward to your updated PR, which should only require that you click a couple of "Commit suggestion" or "Add suggestion to batch" buttons.

This does not appear to have been applied.

I have tried to accept this, but have got into a tangle that I don't know how to untangle. Sorry!

index.html

@David-Chadwick

apply suggestions approved by @David-Chadwick Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

msporny

LGTM as long as @TallTed and my changes are taken into account.

index.html

iherman · 2021-09-09T07:35:26Z

The issue was discussed in a meeting on 2021-09-08

no resolutions were taken

View the transcript

3.1. Credentials and Verifiable Credentials (pr vc-data-model#808)

See github pull request #808.

Brent Zundel: Credentials and Verifiable Credentials - David's raised this, it's responding to an issue.
… I think there's only one question here. David, Ted made a suggestion, actually several, and you approved all of them but one. We weren't sure if that was an oversight or because you didn't agree with the change.
… If you agree, we can commit the suggestion with Ted's approval and get smooth sailing on this PR

Brent Zundel: https://github.com/w3c/vc-data-model/pull/808/files#r698749046

David Chadwick: OK, I thought I had agreed with all these changes. Manu suggested a change today and I've agreed with his change as well. I didn't realize there was one from Ted outstanding. What was it specifically?

Brent Zundel: Here is a link directly to his comment ^
… I assume it had been inadvertency overlooked

David Chadwick: [reads the comment/changes]
… Ah, okay. Right, I don't agree with that change, because I don't think holders do assemble credentials. I thought holders only assemble Verifiable Credentials into a Presentation, and then they made that into a Verifiable Presentation.

Brent Zundel: Excellent, we can move on. The notes from this meeting will automatically populate as a comment into that PR.

David Chadwick: Yes, I disagree with that change, but would like others to comment as well.

Brent Zundel: Folks would like to contribute: we encourage comments there.

brentzundel · 2021-09-14T21:07:50Z

@TallTed were your concerns with this PR addressed to your satisfaction?

index.html

TallTed

@brentzundel @David-Chadwick -- There are two changes that have not yet been applied, one from me, and one from @dlongley (and @msporny), as I've just flagged above.

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

@dlongley

commit suggestion from @dlongley per @David-Chadwick's approval Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>

Signed-off-by: Brent Zundel <brent.zundel@gmail.com>

…wc-credentials

brentzundel · 2021-09-14T22:03:08Z

@David-Chadwick I have committed the suggestions you were having trouble with from @TallTed and @dlongley in cc7befb and 4b50b3b, respectively.
Please let me know if this doesn't meet with your approval.

msporny · 2021-09-15T02:08:15Z

Editorial, multiple reviews, changes requested and made, no objections, merging.

kdenhartog · 2021-11-18T19:15:11Z

There's a linked issue with the Errata label, removing the Errata and Editorial labels from the PR

Credentials and Verifiable Credentials

0b92681

This PR is text for issue #798

TallTed suggested changes Aug 30, 2021

View reviewed changes

kdenhartog added editorial Purely editorial changes to the specification. errata Erratum for a W3C Recommendation v1.1 merge after 14 days labels Aug 31, 2021

kdenhartog mentioned this pull request Aug 31, 2021

Clarify the difference between Credential and Verifiable Credential #798

Closed

Apply suggestions from code review

69ff5f0

apply suggestions approved by @David-Chadwick Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

msporny approved these changes Sep 8, 2021

View reviewed changes

index.html Outdated Show resolved Hide resolved

dlongley reviewed Sep 8, 2021

View reviewed changes

index.html Outdated Show resolved Hide resolved

TallTed reviewed Sep 14, 2021

View reviewed changes

index.html Outdated Show resolved Hide resolved

TallTed suggested changes Sep 14, 2021

View reviewed changes

brentzundel and others added 4 commits September 14, 2021 15:55

Update index.html

c8741b8

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

Apply suggestions from code review

4b50b3b

commit suggestion from @dlongley per @David-Chadwick's approval Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>

Commit @TallTed's suggestion per @David-Chadwick's approval

cc7befb

Signed-off-by: Brent Zundel <brent.zundel@gmail.com>

Merge branch 'dwc-credentials' of github.com:w3c/vc-data-model into d…

a51d993

…wc-credentials

TallTed approved these changes Sep 14, 2021

View reviewed changes

msporny merged commit 1dc83a0 into main Sep 15, 2021

msporny deleted the dwc-credentials branch September 29, 2021 23:41

kdenhartog mentioned this pull request Sep 30, 2021

cherry-pick commits from main to V1.1 #824

Merged

David-Chadwick mentioned this pull request Nov 18, 2021

Clarification of JWT encoding #828

Merged

kdenhartog removed editorial Purely editorial changes to the specification. errata Erratum for a W3C Recommendation labels Nov 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Credentials and Verifiable Credentials #808

Credentials and Verifiable Credentials #808

David-Chadwick commented Aug 30, 2021 •

edited by pr-preview bot

TallTed Aug 30, 2021

TallTed Aug 31, 2021

TallTed Sep 7, 2021

TallTed Sep 8, 2021

David-Chadwick Sep 8, 2021

TallTed Sep 9, 2021

David-Chadwick Sep 9, 2021

TallTed Sep 9, 2021

TallTed Sep 14, 2021

David-Chadwick Sep 14, 2021

msporny left a comment

iherman commented Sep 9, 2021

3.1. Credentials and Verifiable Credentials (pr vc-data-model#808)

brentzundel commented Sep 14, 2021

TallTed left a comment

brentzundel commented Sep 14, 2021

msporny commented Sep 15, 2021

kdenhartog commented Nov 18, 2021

Credentials and Verifiable Credentials #808

Credentials and Verifiable Credentials #808

Conversation

David-Chadwick commented Aug 30, 2021 • edited by pr-preview bot

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msporny left a comment

Choose a reason for hiding this comment

iherman commented Sep 9, 2021

3.1. Credentials and Verifiable Credentials (pr vc-data-model#808)

brentzundel commented Sep 14, 2021

TallTed left a comment

Choose a reason for hiding this comment

brentzundel commented Sep 14, 2021

msporny commented Sep 15, 2021

kdenhartog commented Nov 18, 2021

David-Chadwick commented Aug 30, 2021 •

edited by pr-preview bot