Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable presentationHeader bytes to be optionally passed when deriving a BBS proof #122

Closed
dlongley opened this issue Jan 11, 2024 · 3 comments
Assignees
Labels
pending-close The issue will be closed in 7 days if there are no objections.

Comments

@dlongley
Copy link
Contributor

It would also then need to be included in the serialized disclosure proof CBOR.

@Wind4Greg
Copy link
Collaborator

How would we specify this? My simple approach would be:

To add the BBS presentation header (octet string) as an optional input to the 3.3.6 Add Derived Proof (bbs-2023), which would pass it to 3.2.3 createDisclosureData where it is used by BBS proofGen, then it needs to be passed into an updated 3.2.6 serializeDerivedProofValue which includes it in the CBOR/base64 encoded thing.

I don't really see adding it as a "proof option". Do you @dlongley?

For those wondering about some of the uses of the BBS presentation header see 6.4. Presentation Header Selection where use is RECOMMENDED in most use-cases.

@dlongley
Copy link
Contributor Author

+1 to the approach with the name: presentationHeader

@dlongley
Copy link
Contributor Author

dlongley commented Mar 1, 2024

This was my issue and it's been addressed now, closing.

@dlongley dlongley closed this as completed Mar 1, 2024
@Wind4Greg Wind4Greg added the pending-close The issue will be closed in 7 days if there are no objections. label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-close The issue will be closed in 7 days if there are no objections.
Projects
None yet
Development

No branches or pull requests

2 participants