-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test vectors for BBS Signature Scheme version 05 #117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to getting these in. Thanks!
… pass through, and explicit seed.
Folks, these test vectors have been updated to include the changes requested in issues: #118, #122, #125, and #126. These changes are implemented in PRs: #128, #129, and #131. @TallTed there is some new text at the beginning of section A.2 Derived Proof. Other than that all the changes are in the test vector data. For those interested the code for generating the test vectors can be found in https://github.com/Wind4Greg/ECDSA-SD-TestVectors/tree/main/BBS. Let me know if you have any issues with generating/validating these! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll be trying these against DB's implementation when I get a chance. Thanks!
I checked some of these test vectors successfully against DB's implementation. The only hang up was with the CBOR serialization of byte strings and I've filed an issue related to that: #134. We can merge these as-is and update after that issue is resolved or wait for it -- I'm ok either way. |
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Informative, multiple reviews, changes requested and made, no objections, merging. |
This PR updates the test vectors based on the latest release of the draft BBS specification draft-irtf-cfrg-bbs-signatures-05.
Note that the proof generation/verification procedure has been updated in this version. Test vectors are informative but very helpful to developers. Also the text accompanying the test vectors has not changed only the computed values.
💥 Error: 502 Bad Gateway 💥
PR Preview failed to build. (Last tried on Feb 1, 2024, 5:46 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.