Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test vectors for BBS Signature Scheme version 05 #117

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

Wind4Greg
Copy link
Collaborator

@Wind4Greg Wind4Greg commented Jan 10, 2024

This PR updates the test vectors based on the latest release of the draft BBS specification draft-irtf-cfrg-bbs-signatures-05.

Note that the proof generation/verification procedure has been updated in this version. Test vectors are informative but very helpful to developers. Also the text accompanying the test vectors has not changed only the computed values.


💥 Error: 502 Bad Gateway 💥

PR Preview failed to build. (Last tried on Feb 1, 2024, 5:46 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL

error code: 502

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to getting these in. Thanks!

@Wind4Greg
Copy link
Collaborator Author

Wind4Greg commented Jan 17, 2024

Folks, these test vectors have been updated to include the changes requested in issues: #118, #122, #125, and #126.

These changes are implemented in PRs: #128, #129, and #131.

@TallTed there is some new text at the beginning of section A.2 Derived Proof. Other than that all the changes are in the test vector data.

For those interested the code for generating the test vectors can be found in https://github.com/Wind4Greg/ECDSA-SD-TestVectors/tree/main/BBS. Let me know if you have any issues with generating/validating these!

Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be trying these against DB's implementation when I get a chance. Thanks!

@dlongley
Copy link
Contributor

I checked some of these test vectors successfully against DB's implementation. The only hang up was with the CBOR serialization of byte strings and I've filed an issue related to that: #134. We can merge these as-is and update after that issue is resolved or wait for it -- I'm ok either way.

index.html Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@Wind4Greg
Copy link
Collaborator Author

Folks (@dlongley, @TallTed ), the base example credential was missing the required issuer property. I updated the examples to make sure all credentials produced include this required property.

@Wind4Greg
Copy link
Collaborator Author

Informative, multiple reviews, changes requested and made, no objections, merging.

@Wind4Greg Wind4Greg merged commit 98b6dd1 into w3c:main Feb 5, 2024
2 checks passed
@Wind4Greg Wind4Greg deleted the update-test-vectorsV5 branch February 29, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants