Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Information in chapter 3.4.7 #166

Closed
roblesjoel opened this issue May 20, 2024 · 3 comments
Closed

Missing Information in chapter 3.4.7 #166

roblesjoel opened this issue May 20, 2024 · 3 comments
Assignees

Comments

@roblesjoel
Copy link

roblesjoel commented May 20, 2024

Hey there,

I have two more questions about chapter 3.4.7.

  1. In step 4 of that chapter, you define the "selectedIndexes". In step 6.1 you pass "selectiveIndexes" as an input. I guess a small type there
  2. Also in step 6.1 we have PK, which is the public key of the issuer. There is no doc how one can get that key. I the easiest way would probably be to use the verification Method URL. Would be nice if that was mentioned :)

Thanks!

@Wind4Greg Wind4Greg self-assigned this May 23, 2024
@Wind4Greg
Copy link
Collaborator

Hi @roblesjoel, good catch on the "selectedIndexes" versus "selectiveIndexes". Will fix. On the second point I could include text like they did in the VC-DI-ECDSA spec https://w3c.github.io/vc-di-ecdsa/#proof-verification-ecdsa-rdfc-2019:

Let publicKeyBytes be the result of retrieving the public key bytes associated with the options.verificationMethod value as described in the Data Integrity [VC-DATA-INTEGRITY] specification, Section 4: Retrieve Verification Method.

Would this suffice? Let me know or give me some alternate text and I can write up a PR. Cheers Greg

@roblesjoel
Copy link
Author

Hey @Wind4Greg, yes that would be great as a note on how to retrieve the PK! :)

@msporny
Copy link
Member

msporny commented Jun 28, 2024

PR #167 addressed this issue, closing.

@msporny msporny closed this as completed Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants