Fix variable reference to "selectedIndexes". Add information on public key. #167
Conversation
index.html
Outdated
| @@ -1710,7 +1718,7 @@ <h4>Verify Derived Proof (bbs-2023)</h4> | |||
| disclosed_messages, disclosed_indexes)` of [[CFRG-BBS-SIGNATURE]] with `PK` set | |||
| as the public key of the original issuer, `proof` set as `bbsProof`, `header` | |||
| set as `bbsHeader`, `disclosed_messages` set as `disclosedMessages`, `ph` set as | |||
| `presentationHeader`, and `disclosed_indexes` set as `selectiveIndexes`. | |||
| `presentationHeader`, and `disclosed_indexes` set as `selectedIndexes`. | |||
There was a problem hiding this comment.
Hmm, we might want to go the other way to be consistent with selectivePointers.
The indexes and pointers are ultimately used to select messages (or the information in them) -- so the "selective" terminology works that way. And while the indexes are "selected" that's really via the algorithm based on the selectivePointers -- the real target for selection / disclosure is the messages (or information in them). Either term could probably be used and people wouldn't care that much, so I'd prefer we just be consistent and go with selective.
Presumably this means there's some other location that needs to be changed instead, so I can't make a direct suggestion.
There was a problem hiding this comment.
Variable naming issue selectedIndexes use three times, selectiveIndexes used 25 times. Will make consistent. Good catch.
…o obtain public key information.
|
Debatably normative, multiple reviews, changes requested and made, no objections, merging. |
This editorial PR addresses issue #166 by fixing the name of the variable used and adding information on how to obtain information on the public key used in the signature.
Preview | Diff