Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BbsSignatureProof2020 is broken #62

Closed
OR13 opened this issue Oct 4, 2021 · 3 comments
Closed

BbsSignatureProof2020 is broken #62

OR13 opened this issue Oct 4, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@OR13
Copy link
Contributor

OR13 commented Oct 4, 2021

The current libraries for handling the proof of knowledge are sensitive to disclosed message order, in ways that make certain derived credentials (ones over multiple blank nodes) not verifiable.

This is not a break in the crypto, it is an assumption about revealed statement order which needs to be accounted for.

It's not the job of this suite to define this, but we can't call whatever the solution is BbsSignatureProof2020.... so we will need a new name.

For now, folks interested in this should head over to https://github.com/decentralized-identity/bbs-signature to help.

I suggest we simply rev the year and keep the name the same, so the new proof type will be:

BbsSignatureProof2021, and it won't be sensitive to revealed statement order.

@OR13 OR13 added the bug Something isn't working label Oct 4, 2021
@OR13
Copy link
Contributor Author

OR13 commented Oct 4, 2021

See also: mattrglobal/jsonld-signatures-bbs#158

@OR13
Copy link
Contributor Author

OR13 commented Feb 1, 2022

This issue is still unresolved and the BBS+ work at DIF has chosen to address other issues instead of this issue.

@OR13
Copy link
Contributor Author

OR13 commented May 1, 2023

I'm calling this resolved, since it has been removed from the latest draft.

@OR13 OR13 closed this as completed May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant