-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BbsSignatureProof2020 is broken #62
Labels
bug
Something isn't working
Comments
See also: mattrglobal/jsonld-signatures-bbs#158 |
This issue is still unresolved and the BBS+ work at DIF has chosen to address other issues instead of this issue. |
This was referenced Jan 26, 2023
This was referenced Feb 22, 2023
I'm calling this resolved, since it has been removed from the latest draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current libraries for handling the proof of knowledge are sensitive to disclosed message order, in ways that make certain derived credentials (ones over multiple blank nodes) not verifiable.
This is not a break in the crypto, it is an assumption about revealed statement order which needs to be accounted for.
It's not the job of this suite to define this, but we can't call whatever the solution is
BbsSignatureProof2020
.... so we will need a new name.For now, folks interested in this should head over to https://github.com/decentralized-identity/bbs-signature to help.
I suggest we simply rev the year and keep the name the same, so the new proof type will be:
BbsSignatureProof2021
, and it won't be sensitive to revealed statement order.The text was updated successfully, but these errors were encountered: