Remove "detached". Clarify proofValue meanging
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlongley
reviewed
Jul 24, 2023
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
dlongley
approved these changes
Jul 24, 2023
msporny
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address issue #15. The cited reference, FIPS 186-5 (2023) does not specify a "detached ECDSA signature" it specifies "An ECDSA or deterministic ECDSA digital signature" procedure which is dependent upon having appropriate elliptic curves and hashes specified (which do in the algorithms section of the document).
This PR removes the potentially misleading "detached" term and provides clarification of where to find curve and hash specifics.
Preview | Diff