Simplify language that warns of invalid examples #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seabass-labrax
requested review from
msporny,
martyr280 and
Wind4Greg
as code owners
dlongley
approved these changes
Aug 18, 2023
seabass-labrax
force-pushed
the
warning-invalid-examples
branch
from
37d5f89
to
7ece545
Compare
Wind4Greg
approved these changes
Aug 18, 2023
TallTed
requested changes
Aug 21, 2023
|
To be quite honest, we use this invalid JSON in neither vc-di-eddsa nor vc-di-ecdsa currently. Maybe we should just delete the paragraph entirely, and add something based on what we end up using closer to publication (if any invalid JSON at all).
|
OH! Yes, we should only include the paragraph about invalid JSON in docs where we have such invalid JSON. |
martyr280
approved these changes
Aug 28, 2023
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
msporny
approved these changes
Sep 2, 2023
|
Editorial, multiple reviews, changes requested and made, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains a minor improvement to a paragraph early in the specification. See also w3c/vc-di-eddsa#59.
Preview | Diff