Base proof properties on Data Integrity spec with restrictions #50
Conversation
Wind4Greg
requested review from
msporny,
martyr280 and
seabass-labrax
as code owners
| The `proofPurpose` property of the proof MUST be a string, and MUST | ||
| match the verification relationship expressed by the verification method | ||
| `controller`. |
There was a problem hiding this comment.
I think removing this is ok given that it is covered in:
https://w3c.github.io/vc-data-integrity/#retrieve-verification-method
I filed an issue about cleaning that up a bit here: https://github.com/w3c/vc-data-integrity/issues/236
I'll note that the current text calls this section:
"Section 4: Retrieving Cryptographic Material" instead of "Section 4: Retrieve Verification Method".
I'll also note that the signing section here has the same incorrect title (I'm not sure if some respec magic could keep these things up-to-date), but the way it's phrased there also implies one can get privateKeyBytes from a verification method, which isn't a thing. I think it's just trying to say one gets the private key bytes associated with the verification method identified by options.verificationMethod:
Let privateKeyBytes be the result of retrieving the private key bytes associated with the options.verificationMethod value as described in the Data Integrity [VC-DATA-INTEGRITY] specification, Section 4: Retrieving Cryptographic Material.
Referencing the algorithm should probably just be removed then and we could say:
Let privateKeyBytes be the result of retrieving the private key bytes associated with the verification method identified by the options.verificationMethod value.
But we should probably say: "...privateKeyBytes (or a signing interface enabling the use of the private key bytes) associated with...".
There was a problem hiding this comment.
Hi @dlongley updated text per your suggestion.
Wind4Greg
requested review from
TallTed,
brentzundel,
longpd,
brianorwhatever and
dlongley
|
Normative, multiple reviews, changes requested and made, no objections, merging. |
This PR addresses issue #47. The issue is "Ensure created proof option is optional". However proof options originate in the Data Integrity specification and the created property is properly defined as
optionalthere. Hence this PR points back to the Data Integrity spec for proof property definitions and only elaborates on those properties that have restricted or specially defined values.Preview | Diff