Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong naming for the RDF Canonicalization spec? #78

Closed
iherman opened this issue May 1, 2024 · 1 comment
Closed

Wrong naming for the RDF Canonicalization spec? #78

iherman opened this issue May 1, 2024 · 1 comment
Assignees
@msporny
Labels
CR1 editorial This item is editorial in nature. pr exists A Pull Request exists to address this issue.

Comments

@iherman
Copy link
Member

iherman commented May 1, 2024

The reference, in https://www.w3.org/TR/vc-di-eddsa/#eddsa-rdfc-2022 says "Universal RDF Dataset Canonicalization Algorithm", whereas the official title in the relevant specification is "RDF Dataset Canonicalization". The word "Universal" is meaningless and should be removed (I presume this is a leftover from the name of the predecessor algorithm).

The same error happens in https://www.w3.org/TR/vc-di-ecdsa/#ecdsa-rdfc-2019.
@iherman iherman added the editorial This item is editorial in nature. label May 1, 2024
This was referenced Jun 9, 2024
Merged
Merged
@iherman iherman added the pr exists A Pull Request exists to address this issue. label Jun 25, 2024
@msporny msporny self-assigned this Jun 28, 2024
@msporny msporny added the CR1 label Jun 28, 2024
@msporny
Copy link
Member

msporny commented Jun 30, 2024

PR #83 has been merged to address this issue, closing.

@msporny msporny closed this as completed Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msporny msporny

Labels
CR1 editorial This item is editorial in nature. pr exists A Pull Request exists to address this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msporny @iherman