Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eddsa-jcs-2022 and nested documents #81

Closed
silverpill opened this issue May 9, 2024 · 2 comments
Closed

eddsa-jcs-2022 and nested documents #81

silverpill opened this issue May 9, 2024 · 2 comments
Assignees
Labels
CR1 editorial This item is editorial in nature.

Comments

@silverpill
Copy link

Should any additional steps be performed when nested documents are being secured?

Example:

{
  "@context": [
    "https://www.w3.org/ns/activitystreams",
    "https://w3id.org/security/data-integrity/v2"
  ],
  "type": "Create",
  "object": {
    "@context": [
      "https://www.w3.org/ns/activitystreams",
      "https://w3id.org/security/data-integrity/v2"
    ],
    "type": "Note",
    "content": "test",
    "proof": {
      "@context": [
        "https://www.w3.org/ns/activitystreams",
        "https://w3id.org/security/data-integrity/v2"
      ],
      "type": "DataIntegrityProof",
      "cryptosuite": "eddsa-jcs-2022"
    }
  },
  "proof": {
    "@context": [
      "https://www.w3.org/ns/activitystreams",
      "https://w3id.org/security/data-integrity/v2"
    ],
    "type": "DataIntegrityProof",
    "cryptosuite": "eddsa-jcs-2022"
  }
}

The document with type Note is secured first, then it is inserted into the document with type Create under the object property, then Create document is secured too. Here, I'm assuming that #79 will be merged. Some properties are omitted for brevity.

Is the resulting document valid?

@msporny msporny self-assigned this Jun 28, 2024
@msporny msporny added editorial This item is editorial in nature. CR1 labels Jun 28, 2024
@msporny
Copy link
Member

msporny commented Jun 30, 2024

The Editors met and discussed this issue this past Friday. What you are doing is valid and secure.

Should any additional steps be performed when nested documents are being secured?

No.

The document with type Note is secured first, then it is inserted into the document with type Create under the object property, then Create document is secured too.

That is fine, everything is secured.

Here, I'm assuming that #79 will be merged.

Yep, that got merged.

Is the resulting document valid?

Yep, you're all good.

@msporny
Copy link
Member

msporny commented Jun 30, 2024

The Editors believe that the usage described is valid and, therefore, no other changes to the specification are required. Closing.

@msporny msporny closed this as completed Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR1 editorial This item is editorial in nature.
Projects
None yet
Development

No branches or pull requests

2 participants