-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
credentialSchema property not fully correct in PR#159 examples #164
Comments
I can't seem to find this. Maybe it has been fixed? Please let me know if you still see it. |
This is because the second and third tabs have been removed from the example. I do not know which PR did this, but I would have thought that the correct approach was to fix the tabs rather than to remove them. Personally I found the tabs to be useful as they showed how the VC evolved to be a JWT |
@OR13 thoughts? |
The tabs (both labels and content) of this example have been changed substantially, but I don't think anything has been removed. See the latest Editor's Draft. Look particularly to where I believe that the concern about |
The tabs have come back and now the content is correct, so this issue can be closed. I suspect that @decentralgabe and myself viewed a temporary draft that was in the process of being fixed as a result of this issue (the first step being to remove wrong content, and the second step being to add the corrected content). |
Whilst the first tab of Example 1 (application/vc+ld+json) is correct, I do not believe that the third tab (application/vc+ld+json+sd-jw) is correct as it places the credentialSchema as a property of the credentialSubject
The text was updated successfully, but these errors were encountered: