Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal Review Tracking #195

Closed
4 of 5 tasks
decentralgabe opened this issue Dec 20, 2023 · 6 comments
Closed
4 of 5 tasks

Horizontal Review Tracking #195

decentralgabe opened this issue Dec 20, 2023 · 6 comments

Comments

@decentralgabe
Copy link
Collaborator Author

Likely the first two can be closed. It does not look like security reviews have had any response whatsoever (for anyone) in the past 2 years. So we are just waiting on closing PING.

@TallTed

This comment was marked as resolved.

@decentralgabe
Copy link
Collaborator Author

looks like #125 will be closed after #192

@iherman
Copy link
Member

iherman commented Jan 9, 2024

The issue was discussed in a meeting on 2024-01-09

  • no resolutions were taken
View the transcript

1.2. Unclear semantics wrt. JWT claims vs. VC properties (issue vc-jose-cose#205)

See github issue vc-jose-cose#205.

Manu Sporny: one of the big mistakes with the jwt stuff in v1 and 1.1. was the mapping or not of iss to issuer.
… we should not provide two ways to do this mapping this time round. We should be consistent.
… hoping for text that makes this very clear.
… think there are only three fields that we need to provide explicit guidance on.
… raised issue 205 to track this.

Michael Jones: gabe has agreed to take this on. we agree there should be one way to do the mapping.
… agree there is a small number of fields we want to say something about.
… think we are on track.

See github issue vc-jose-cose#195.

Michael Jones: moving on to issue 195. To do with horizontal review.
… more of a progress report.

@iherman
Copy link
Member

iherman commented Jan 9, 2024

The issue was discussed in a meeting on 2024-01-09

  • no resolutions were taken
View the transcript

1.3. Horizontal Review Tracking (issue vc-jose-cose#195)

See github issue vc-jose-cose#195.

See github issue vc-jose-cose#192.

Michael Jones: This is related to issue 192.
… kyle didn't like language in the spec around securing with sd-jwt and JOSE. Neither result in a testable conformant statement.
… manu raised an issue around conformance classes.
… can satisfy Kyle by using conformance profiles to create testable statements.

Manu Sporny: +1 I agree this would address mine and kyles concerns.
… on issue 195, the TAG isn't in the HR tracking, may want to add.
… We need to get a response from security before we close the issue.
… Don't need it to go into CR, but don't close issues on other groups trackers.

Brent Zundel: I know review request was submitted in May 2023.

Manu Sporny: -> w3ctag/design-reviews#899.

Brent Zundel: TAG has an issue that is design review, that is closed on orie's request because of text changes.
… new one has been opened. Issue 899 in September 23.
… Looks like they are planning to discuss in the f2f in London this month.

Michael Jones: can you add this to Horizontal Review issue 195.
… another progress report - issue 206.

@decentralgabe
Copy link
Collaborator Author

Closing as #192 has been completed, and the PING review has closed. Horizontal review has been completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants