Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify relationship between "iss" and "issuer" #22

Closed
selfissued opened this issue Sep 16, 2022 · 7 comments
Closed

Clarify relationship between "iss" and "issuer" #22

selfissued opened this issue Sep 16, 2022 · 7 comments

Comments

@selfissued
Copy link
Collaborator

The VC Data Model spec says this about the issuer:

The value of the issuer property MUST be either a URI or an object containing an id property.

The VC-JWT spec says this about the issuer:

iss MUST represent the issuer property of a verifiable credential or the holder property of a verifiable presentation.

The JWT spec says this about iss:

The "iss" value is a case-sensitive string

That means that that if issuer is an object containing an id property, it is incompatible with iss, since iss is a string. We clearly need language describing this type mismatch and how to avoid it and/or what the iss value must be when issuer is an object that is not a string.

Attn: @OR13

@OR13
Copy link
Contributor

OR13 commented Sep 19, 2022

I don't agree, I think issuer as an object is legal according to the core data model, and compatible with iss WHEN, a clean mapping in normative text exists of the following format:

If issuer is a string, iss MUST match issuer.

If issuer is an object with an id value, iss MUST match the id value.

This is how we support JWT / Data Integrity Proof graph based interoperability today.

The solution is to refine the production / consumption rules to make these transformations unambiguous.

@selfissued
Copy link
Collaborator Author

Can you write a PR to do this, @OR13 ?

The solution is to refine the production / consumption rules to make these transformations unambiguous.

Do you agree with this proposed resolution, @Sakurann ?

@TallTed
Copy link
Member

TallTed commented Oct 20, 2022

Does iss map to issuer or issuanceDate? See https://github.com/w3c/vc-jwt/pull/11/files#r1000766891

@Sakurann
Copy link
Contributor

Does iss map to issuer or issuanceDate?

In v1.1 it's issuer.

@alenhorvat
Copy link

If issuer is a string, iss MUST match issuer.
If issuer is an object with an id value, iss MUST match the id value.

Fully support this.

@OR13
Copy link
Contributor

OR13 commented Jun 30, 2023

#111 (comment)

^ related

@Sakurann
Copy link
Contributor

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants