Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(English) references to the VCDM spec are wrong in the 1.1 section #66

Closed
iherman opened this issue Mar 28, 2023 · 4 comments
Closed

(English) references to the VCDM spec are wrong in the 1.1 section #66

iherman opened this issue Mar 28, 2023 · 4 comments

Comments

@iherman
Copy link
Member

iherman commented Mar 28, 2023

Provided that the answer to the question in #65 is that the 1.1 section should be left in the spec (albeit updated), there are a number of references to the VCDM which are wrong. For example, §2.2.1 starts with

To encode a verifiable credential as a JWT, specific properties introduced by this specification MUST be either:

but the English references "by this specification" is wrong: it should be replaced by a reference to the VCDM spec. This is an obvious leftover of the fact that this part of the spec was copy pasted from the VCDM 1.1 document. The whole §2.2 section should be revised in this respect. This must be done, in my view, before this document is published as a FPWD.

@TallTed
Copy link
Member

TallTed commented Mar 28, 2023

This must be done, in my view, before this document is published as a FPWD.

It will cause no harm to publish FPWD before this (known issue, tracked here) is fixed.

@OR13
Copy link
Contributor

OR13 commented Apr 1, 2023

I have started to address this in #68

It will probably take a few passes to make these sections read smoother.

@OR13
Copy link
Contributor

OR13 commented Jun 30, 2023

This issue is stale and should be closed.

@OR13
Copy link
Contributor

OR13 commented Jul 19, 2023

Marked pending close over 1 week ago, closing.

@OR13 OR13 closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants