Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy JWT section #1

Merged
merged 1 commit into from Aug 4, 2022
Merged

Copy JWT section #1

merged 1 commit into from Aug 4, 2022

Conversation

OR13
Copy link
Contributor

@OR13 OR13 commented Jul 20, 2022

@OR13
Copy link
Contributor Author

OR13 commented Jul 20, 2022

cc @selfissued @mprorock PR Previews are already working, but I don't know where this will publish after merged.

@iherman
Copy link
Member

iherman commented Jul 21, 2022

cc @selfissued @mprorock PR Previews are already working, but I don't know where this will publish after merged.

This will merge into (essentially replace) the index.html file of the repository and will work with the github.io address, but I am sure you know that...

I suspect you expect this to become automatically an official FPWD, but that is, alas!, not that simple. My apologies if you already know all that, but in case you do not:

  • There must be an official WG resolution for a text to be officially published as a FPWD (which should not be the respec source text but the static, generated version thereof)
  • The candidate text for the FPWD must be checked with the pubrules' checker (see https://www.w3.org/pubrules/)
  • I have to manually push a version of the spec onto the w3c server via cvs
  • We have to officially request the director to approve the FPWD and then, as a second step, the webmaster to really publish it on /TR.

All the admin steps will be done by yours truly, but generating the final version of the document is the responsibility of the editor.

I know it is a lot of admin, but it is necessary. The FPWD step means that the documents become one of the hardcore, official documents in W3C system, it becomes part of the search index for documents, it triggers the IPR procedures, and all that.

Once this is done we can set up ECHIDNA and then every such merge will also update the official version. The next time we will have to make such hard administration is when publishing a Candidate Recommendation, but that is still far away.

Does this also answer w3c/vc-jws-2020#6 (comment) ?

@OR13
Copy link
Contributor Author

OR13 commented Jul 21, 2022

@iherman we are not planning on doing any FPWD (until we have WG resolutions), we just want a stable URL for editors drafts.

Is it not possible to setup publishing for ED without going through the FPWD bit first?

@iherman
Copy link
Member

iherman commented Jul 21, 2022

The editors draft URL is:

https://w3c.github.io/vc-jwt/

That is already working and displays the empty respec shell that I created for the new repo

<html lang="en">
<head>
<meta charset="utf-8">
<meta charset="utf-8" />
<title>JSON Web Token</title>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<title>JSON Web Token</title>
<title>JSON Web Token</title>

Give there is already a JWT spec, we might want to rename the title of the spec to something like: "Securing Verifiable Credentials using JSON Web Token". I expect that might need to become the by-line (because of the size of the font for spec titles) and the title might be something like "Using JWTs for Verifiable Credentials".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will handle content changes in a subsequent PR, I want to keep the content as is for this one.

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a first Editors Draft.

Copy link
Collaborator

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, Orie.

@iherman
Copy link
Member

iherman commented Aug 4, 2022

The issue was discussed in a meeting on 2022-08-03

  • no resolutions were taken
View the transcript

5.10. Migrate Section 6.3.1 JSON Web Token to separate normative specification (issue vc-data-model#880)

See github issue vc-data-model#880.

Kristina Yasuda: Not sure if it's done already.
… or if PR is there but not merged..
… This is less a move-it and rather a close-it, right?.

Manu Sporny: +1 to that. I think Kristina suggested as much in the last comment on the issue.

Michael Jones: I think this is being accomplished by VC-JWT PR 1.

Brent Zundel: I will take off the vc-jwt? label.

Michael Jones: Maybe reference VC-JWT pull-request 1.

See github pull request vc-jwt#1.

Brent Zundel: looks like that's in the comment from Orie.
… Thank you all for going through these.

Michael Jones: +1.

Brent Zundel: After the meeting, anything still labeled "vc-jwt?" will be moved to the vc-jwt repo..

@iherman
Copy link
Member

iherman commented Aug 4, 2022

The issue was discussed in a meeting on 2022-08-03

  • no resolutions were taken
View the transcript

5. Status Report: VC-JWT.

See github pull request vc-jwt#1.

Orie Steele: As noted by that PR, there was an agreement last time to copy over the VC-JWT section..
… I think I've seen PRs on the vc-data-model already to remove that content..

Manu Sporny: Migrate VC-JWT section to dedicated specification -- w3c/vc-data-model#899 #1.

Orie Steele: My preference for VC-JWT is that we merge this PR; VC-JWT starts to have content under an ED.
… and we keep pulling off content and issues into that repo..
… This PR is the first implementing that process..

Brent Zundel: https://github.com/w3c/vc-data-model/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-asc+label%3vc-jwt%3F.

Brent Zundel: Additional piece of business for this topic, broadly: go through issues here to transfer..

Brent Zundel: https://github.com/w3c/vc-data-model/issues?q=is%3Aopen+is%3Aissue+label%3Avc-jwt%3F+sort%3Aupdated-asc.

Brent Zundel: This is all the issues in the VC Data Model repository that the chairs felt were probably VC-JWT related..
… We're not processing except to see if should go to VC-JWT or not..
… Going through one at a time....

@brentzundel
Copy link
Member

With the approvals thus far, and after the conversation yesterday, I think we are clear to merge this.

@OR13 OR13 merged commit bfcd55e into main Aug 4, 2022
@OR13 OR13 deleted the feat/copy-jwt-section branch June 7, 2023 17:42
@iherman iherman mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants