Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong content type and CORS headers not set #9

Closed
yancyribbens opened this issue Mar 20, 2019 · 7 comments
Closed

Wrong content type and CORS headers not set #9

yancyribbens opened this issue Mar 20, 2019 · 7 comments
Assignees
Labels

Comments

@yancyribbens
Copy link
Contributor

I believe the content type is wrong for the required context: https://w3.org/2018/credentials/v1. Example test suite file failes to load using the json-ld playground

@davidlehn
Copy link
Contributor

You should be using this:
https://www.w3.org/2018/credentials/v1
Seems the non-www redirect isn't working via CORS.
That example won't process correctly since the other "example" context URL doesn't actually exist.

@yancyribbens
Copy link
Contributor Author

Thanks, i'll put in a PR to fix: https://github.com/w3c/vc-test-suite/blob/gh-pages/test/vc-data-model-1.0/input/example-1.jsonld#L3 for example.

Even though not including www does fix some issues by not redirecting, I think the content type should still be fixed.

@yancyribbens
Copy link
Contributor Author

yancyribbens commented Mar 23, 2019

PR to use www to avoid redirect is here: #10

@dmitrizagidulin
Copy link
Collaborator

Addressed by merged PR #10.

@msporny msporny changed the title wrong content type Wrong content type and CORS headers not set Apr 23, 2019
@dlongley
Copy link
Contributor

We need this header added at a minimum:

Access-Control-Allow-Origin: *

https://annevankesteren.nl/2012/12/cors-101

And I think that's it wrt to addressing the CORS issue.

@burnburn
Copy link
Collaborator

@burnburn to ask @ashimura about status.

@dlongley
Copy link
Contributor

This appears to be resolved:

curl -I https://www.w3.org/2018/credentials/v1
HTTP/2 200 
date: Tue, 13 Aug 2019 14:46:13 GMT
content-type: application/ld+json
last-modified: Tue, 13 Aug 2019 14:10:44 GMT
etag: "5d52c4e4-1e07"
access-control-allow-origin: *
expires: Tue, 13 Aug 2019 14:56:13 GMT
cache-control: max-age=600
x-proxy-cache: MISS
x-github-request-id: B5FE:4DDF:765912:AC4ABA:5D52CD33
content-length: 7687
accept-ranges: bytes
via: 1.1 varnish
age: 0
x-served-by: cache-jfk8120-JFK
x-cache: MISS
x-cache-hits: 0
x-timer: S1565707574.695532,VS0,VE15
vary: Accept-Encoding
x-fastly-request-id: d29055a709963a838a244097b58fd7373ce66903
strict-transport-security: max-age=15552000; includeSubdomains; preload
content-security-policy: upgrade-insecure-requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants