cleanup of index.html #111

TallTed · 2019-08-23T20:16:30Z

normalized whitespace
fixed various typos
fixed nested lists
fixed incorrect h2/h3/h4 levels

Preview | Diff

* normalized whitespace * fixed various typos * fixed nested lists * fixed incorrect h2/h3/h4 levels

* fixed broken `img` markup

TallTed · 2019-08-23T20:47:33Z

There are also a number of <ol> that should probably be changed to <ul>.

TallTed · 2019-08-27T20:49:35Z

Conflicts resolved; should be mergeable.

ken-ebert · 2019-08-28T17:36:12Z

This looks like it makes only changes to the internal organization of the html, but no substantive changes to the text. Is that correct?

TallTed · 2019-08-28T17:51:28Z

@ken-ebert - Yes, "changes to the internal organization of the html, but no substantive changes to the text" is the intent.

ken-ebert · 2019-08-28T18:02:23Z

@TallTed You did a huge amount of work to make this all consistent. Do I need to review the changes in my recently merged PR#105 regarding device use cases to perform a similar cleanup?

same cleanup applied to text from #105

TallTed · 2019-08-28T18:39:26Z

@ken-ebert -- Thanks for noticing I'd overlooked that! Handled.

index.html

fixed Carol/Certifications Testing Lab and Vince/VAR Resellers details

TallTed · 2019-08-28T19:11:33Z

Also changed details about update application, removing reference there to Vince.

ken-ebert

It looks good to me.

stonematt · 2019-08-30T15:56:42Z

You Gus are awesome! Reviewing now

TallTed · 2019-08-30T21:11:03Z

Something huge got merged, with lots of whitespace changes, and lots of <a> insertions. I've started resolving the conflicts -- but there are many, and they are large, so it's going to take me some time ... and I will probably not be able to complete this task until Sunday, as I'm actively moving house even-as-I-type.

stonematt · 2019-08-30T21:42:02Z

that was me -- I added tags for glossary terms across the doc. I was planning (expecting) to be the one to fix it w/ your PR. how can I help?

stonematt · 2019-09-01T15:37:45Z

@TallTed . I didn’t know the best way to resolve conflicts in this PR, so I started or #115. I would really appreciate a review if you can.

TallTed · 2019-09-03T14:09:16Z

@TallTed . I didn’t know the best way to resolve conflicts in this PR, so I started or #115. I would really appreciate a review if you can.

@stonematt - Regrettably, the best way to handle this would have been to merge #111 before the across-the-board glossary tagging -- or to take the same steps to apply the same tags to #111 before trying to merge it. I don't think reverting commits will be optimal at this point.

GitHub's tools don't offer a good way to address the current state of things.

External editors (with a bit more hoop-jumping) can allow for side-by-side comparisons of any two versions, and can do a better job of flagging differences at the character level (such as the <a> additions) with or without flagging whitespace changes.

I'll take a crack at this (putting #111 against #115 in BBEdit) today, and make my comments on #115. Please don't close #111 until #115 is finalized and merged.

stonematt · 2019-09-03T14:53:14Z

thanks @TallTed I focused on whitespace and line length in the committs in pr #115

TallTed · 2019-09-03T20:31:28Z

I can't win... I just did a huge cross-compare between #115 and #111, and made #111 almost completely fixed by pasting a unified set of changes here.

But there are still a LOT of conflicts with the upstream.

Also --

There remain some <ol> which should be <ul>, and possibly vice-versa.
"Claim" and "Credential" appear to be used inconsistently, sometimes apparently intended to mean the same thing, and sometimes appearing to mean what we've been talking about with the other term for some time.
There are doubled images in at least 3 places, because there's both an SVG and a PNG for each, and I'm not sure which was produced/corrected later (file and commit dates cannot be trusted for this). These do not display properly in the PREVIEW because something in that tool sets file permissions incorrectly, resulting in things like the following for https://pr-preview.s3.amazonaws.com/w3c/vc-use-cases/pull/user-roles.svg --

<Error>
<Code>AccessDenied</Code>
<Message>Access Denied</Message>
<RequestId>02F28DD5CCD62DE7</RequestId>
<HostId>
a/YR1yAT9Wz81jl2h1/iRxO7z94k4YQrVLt2/rk5FQyIMFo51Q5ZkqXj6SCCnOmF4QcbmJCnd+o=
</HostId>
<style id="stylebot-global-css">
pre, code, kbd, samp, tt {font-family: monospace,monospace !important;font-size: 1em !important;}textarea {font-family: monospace !important;}
</style>
</Error>

ken-ebert · 2019-09-10T14:31:19Z

index.html

+describes a quality or qualities, property or properties of an <a>entity</a>
+which establish its existence and uniqueness. The use cases outlined here are
+provided in order to make progress toward possible future standardization and
+interoperability of both low and high-stakes <a>claims</a> with the goals of


"low" to "low-"

This is an editorial nit.

ken-ebert

All of the new changes look good to me.

ken-ebert · 2019-09-10T20:11:23Z

After looking at the document after merge, I noticed that Figure 2 Verifiable Credentials, Example Domains for User Needs seems to be duplicative of Figure 3 Verifiable Credentials, Example Domains for User Needs. I think that Figure 2 should be deleted.

ken-ebert · 2019-09-10T20:19:13Z

"EXAMPLE 3: Amanda's passport" -> EXAMPLE 3: Anand's passport"
"Example 4: Amanda's birth certificate" -> ""Example 4: Anand's birth certificate"

TallTed added 2 commits August 23, 2019 16:16

Update index.html

a70622c

* normalized whitespace * fixed various typos * fixed nested lists * fixed incorrect h2/h3/h4 levels

Update index.html

22d68b8

* fixed broken `img` markup

TallTed requested review from jandrieu and stonematt August 27, 2019 15:20

brentzundel approved these changes Aug 27, 2019

View reviewed changes

Merge branch 'gh-pages' into TallTed-20190822-vcuc-cleanup

16a46b2

ken-ebert approved these changes Aug 28, 2019

View reviewed changes

Update index.html

a4a1513

same cleanup applied to text from #105

ken-ebert reviewed Aug 28, 2019

View reviewed changes

index.html Outdated Show resolved Hide resolved

ken-ebert reviewed Aug 28, 2019

View reviewed changes

index.html Outdated Show resolved Hide resolved

Update index.html

85e90f3

fixed Carol/Certifications Testing Lab and Vince/VAR Resellers details

ken-ebert reviewed Aug 29, 2019

View reviewed changes

stonematt mentioned this pull request Sep 1, 2019

Cleanup index.html v2 #115

Closed

Update index.html

e5ee39b

TallTed mentioned this pull request Sep 3, 2019

does this result in fewer conflicts? #116

Closed

ken-ebert reviewed Sep 10, 2019

View reviewed changes

TallTed added 2 commits September 10, 2019 13:47

Merge branch 'gh-pages' into TallTed-20190822-vcuc-cleanup

1bf0d95

Update index.html

d7509d3

ken-ebert approved these changes Sep 10, 2019

View reviewed changes

Update index.html

07a6ac1

TallTed merged commit a2ac4d3 into gh-pages Sep 10, 2019

rhiaro mentioned this pull request Sep 10, 2019

Prepare for NOTE publication #119

Merged

TallTed deleted the TallTed-20190822-vcuc-cleanup branch September 11, 2019 18:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cleanup of index.html #111

cleanup of index.html #111

TallTed commented Aug 23, 2019 •

edited by pr-preview bot

TallTed commented Aug 23, 2019

TallTed commented Aug 27, 2019

ken-ebert commented Aug 28, 2019 •

edited

TallTed commented Aug 28, 2019

ken-ebert commented Aug 28, 2019 •

edited

TallTed commented Aug 28, 2019

TallTed commented Aug 28, 2019

ken-ebert left a comment

stonematt commented Aug 30, 2019

TallTed commented Aug 30, 2019

stonematt commented Aug 30, 2019

stonematt commented Sep 1, 2019

TallTed commented Sep 3, 2019

stonematt commented Sep 3, 2019

TallTed commented Sep 3, 2019 •

edited

ken-ebert Sep 10, 2019

ken-ebert Sep 10, 2019

ken-ebert left a comment

ken-ebert commented Sep 10, 2019

ken-ebert commented Sep 10, 2019

cleanup of index.html #111

cleanup of index.html #111

Conversation

TallTed commented Aug 23, 2019 • edited by pr-preview bot

TallTed commented Aug 23, 2019

TallTed commented Aug 27, 2019

ken-ebert commented Aug 28, 2019 • edited

TallTed commented Aug 28, 2019

ken-ebert commented Aug 28, 2019 • edited

TallTed commented Aug 28, 2019

TallTed commented Aug 28, 2019

ken-ebert left a comment

Choose a reason for hiding this comment

stonematt commented Aug 30, 2019

TallTed commented Aug 30, 2019

stonematt commented Aug 30, 2019

stonematt commented Sep 1, 2019

TallTed commented Sep 3, 2019

stonematt commented Sep 3, 2019

TallTed commented Sep 3, 2019 • edited

ken-ebert Sep 10, 2019

Choose a reason for hiding this comment

ken-ebert Sep 10, 2019

Choose a reason for hiding this comment

ken-ebert left a comment

Choose a reason for hiding this comment

ken-ebert commented Sep 10, 2019

ken-ebert commented Sep 10, 2019

TallTed commented Aug 23, 2019 •

edited by pr-preview bot

ken-ebert commented Aug 28, 2019 •

edited

ken-ebert commented Aug 28, 2019 •

edited

TallTed commented Sep 3, 2019 •

edited