Refactor "Other Deliverables" section #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msporny
commented
Mar 1, 2022
| <li>VC JSON Web Tokens</li> | ||
| </ul> | ||
| </li> | ||
| <li>Extensions for binding multilingual resources for localized user interfaces.</li> |
There was a problem hiding this comment.
This was moved up to line 319.
Comment on lines
-333
to
-337
| <li>Test suites for verifiable credential proof types: | ||
| <ul> | ||
| <li>VC Data Integrity - Ed25519</li> | ||
| <li>VC Data Integrity - BBS+</li> | ||
| <li>VC JSON Web Tokens</li> |
There was a problem hiding this comment.
These were condensed to line 315.
index.html
Outdated
Comment on lines
322
to
324
| <li>Verifiable Credential Exchange over [GNAP](https://datatracker.ietf.org/doc/html/draft-ietf-gnap-core-protocol)</li> | ||
| <li>Verifiable Credential Exchange over <a href="https://datatracker.ietf.org/doc/html/draft-ietf-gnap-core-protocol">GNAP</li> |
There was a problem hiding this comment.
Fixing markdown (this isn't a markdown document) -> HTML.
msporny
requested review from
iherman,
Sakurann,
TallTed,
brentzundel,
jricher,
mprorock and
OR13
brentzundel
approved these changes
Mar 1, 2022
Sakurann
reviewed
Mar 1, 2022
| <li>Presentation Request Data Model</li> | ||
| <li>Storage and Sharing of Verifiable Credentials</li> | ||
| <li>Privacy Guidance for Verifiable Credentials</li> | ||
| <li>Extensions for binding multilingual resources for localized user interfaces.</li> | ||
| <li>A Developer Guide consisting of one or more notes related to general implementation guidance and best practices for working with VCs, including but not limited to: | ||
| <ul> | ||
| <li>One or more HTTP protocol definitions for Verifiable Credential Exchange (such as the <a href="https://w3c-ccg.github.io/vc-api/">VC-API</a>)</li> | ||
| <li>Guidance on Verifiable Credential Exchange over OpenID Connect</li> |
There was a problem hiding this comment.
adding suggestions since there was support to add URLs to OIDC specs when we added GNAP:
Suggested change
| <li>Guidance on Verifiable Credential Exchange over OpenID Connect</li> | |
| <li>Verifiable Credential Exchange over <a href="https://openid.net/specs/openid-connect-core-1_0.html">OpenID Connect</a>:</li> | |
| <ul> | |
| <li><a href="https://openid.net/specs/openid-connect-self-issued-v2-1_0.html">Self-Issued OpenID Provider v2</a></li> | |
| <li><a href="https://openid.net/specs/openid-connect-4-verifiable-presentations-1_0.html">OpenID Connect for Verifiable Presentations</a></li> | |
| <li><a href="https://openid.net/specs/openid-connect-4-verifiable-credential-issuance-1_0.html">OpenID Connect for Verifiable Credential Issuance</a></li> | |
| </ul> |
(Happy to do a separate PR, but I think this fits here)
There was a problem hiding this comment.
@Sakurann if you are fine raising a separate PR for these changes, we can merge this PR now.
Sakurann
approved these changes
Mar 1, 2022
tplooker
approved these changes
Mar 1, 2022
iherman
approved these changes
Mar 1, 2022
brentzundel
approved these changes
Mar 1, 2022
OR13
approved these changes
Mar 1, 2022
jricher
approved these changes
Mar 1, 2022
TallTed
reviewed
Mar 1, 2022
TallTed
reviewed
Mar 1, 2022
editorial fixes from TallTed Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
|
@Sakurann please raise a new PR for the changes you recommend in your comment here Merging in accordance with our current working mode. |
Uh oh, the merge was done w/o changing the target branch, so this will never be applied to the main branch. Trying to fix now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the "Other Deliverables" section by:
Preview | Diff