Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input documents column to conditional deliverables #92

Merged
merged 3 commits into from
Mar 4, 2022

Conversation

brentzundel
Copy link
Member

@brentzundel brentzundel commented Mar 2, 2022

this PR fixes #90

Signed-off-by: Brent Zundel brent.zundel@gmail.com


Preview | Diff

Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@@ -273,30 +273,42 @@ <h3>
<tr>
<th>Specification</th>
<th>Description</th>
<th>Input Documents</th>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with this column, I almost added it in a separate PR.

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>
@iherman
Copy link
Member

iherman commented Mar 3, 2022

The issue was discussed in a meeting on 2022-03-02

  • no resolutions were taken
View the transcript

4.2. Add input documents column to conditional deliverables (pr vc-wg-charter#92)

See github pull request vc-wg-charter#92.

Brent Zundel: Next up #92.
… adds an input documents to conditional deliverables.
… The names I made up on the spot, so we can bikeshed if desired.

Manu Sporny: the core thing that these PR does is add an inputs document column. To address what an input document is. This worked for the Registries PR.
… two concerns. there probably needs to be a general clean up re how we talk about these various deliverables.
… +1 to addition of column. -1 to some of the names.
… we need a discussion to figure out the names before we lock into that.

Brent Zundel: structurally, I think this addresses some of the concerns about the additional deliverables..

Joe Andrieu: -1 to merging without name fixing, but if acknowledged we could do that later.

Brent Zundel: anyone opposed to merging as is?

Manu Sporny: yes..

Joe Andrieu: me too.

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be a +1 to merge if my change suggestions are taken. The most important part of this PR is the addition of the 3rd "input document" column, let's get that in first and then try and reconcile the name of these deliverables.

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>
@brentzundel
Copy link
Member Author

Requested changes have been made, approvals from both chairs, merging.

@brentzundel brentzundel merged commit 53f1da0 into w3c:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conditional deliverables section should have an input documents section
4 participants