-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation of repo-manager based on latest changes to it #26
Conversation
@chaals care to review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor tweaks to some of Robin's original text
repo-management.html
Outdated
@@ -136,17 +127,17 @@ | |||
<h3>PR Details</h3> | |||
<p> | |||
If the PR is not in an acceptable state, this will list problematic users with a link to fix | |||
them each. The fix can either be "Add to system" or "Edit" (details below). | |||
them each, and alternatively a button to "Mark the PR as non-substantive".</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/them each/each of them/
s/alternatively//
repo-management.html
Outdated
people who are simply not known, but that relatively quickly it ought to become a less | ||
frequent occurrence. | ||
The idea is that the vast majority of non-acceptable PRs for a newly added repo will come from | ||
people who are simply not known. | ||
</p> | ||
<p> | ||
If it so happens that all of the problematic users can be added to the system or to the right | ||
group, and that you have done so, then you can return to the PR details page and hit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/so happens.*done so, then you can/all problematic users are added to the system and group,/
repo-management.src
Outdated
@@ -116,17 +107,17 @@ | |||
<h3>PR Details</h3> | |||
<p> | |||
If the PR is not in an acceptable state, this will list problematic users with a link to fix | |||
them each. The fix can either be "Add to system" or "Edit" (details below). | |||
them each, and alternatively a button to "Mark the PR as non-substantive".</p> | |||
<p>For problematic users, the fix can either be "Add to system" or "Edit" (details below). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see matching comment
repo-management.src
Outdated
people who are simply not known, but that relatively quickly it ought to become a less | ||
frequent occurrence. | ||
The idea is that the vast majority of non-acceptable PRs for a newly added repo will come from | ||
people who are simply not known. | ||
</p> | ||
<p> | ||
If it so happens that all of the problematic users can be added to the system or to the right | ||
group, and that you have done so, then you can return to the PR details page and hit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see matching comment
Adresses w3c/ash-nazg#70