Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation of repo-manager based on latest changes to it #26

Merged
merged 2 commits into from
Apr 19, 2017

Conversation

dontcallmedom
Copy link
Member

Adresses w3c/ash-nazg#70

@dontcallmedom
Copy link
Member Author

@chaals care to review?

Copy link

@chaals chaals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor tweaks to some of Robin's original text

@@ -136,17 +127,17 @@
<h3>PR Details</h3>
<p>
If the PR is not in an acceptable state, this will list problematic users with a link to fix
them each. The fix can either be "Add to system" or "Edit" (details below).
them each, and alternatively a button to "Mark the PR as non-substantive".</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/them each/each of them/
s/alternatively//

people who are simply not known, but that relatively quickly it ought to become a less
frequent occurrence.
The idea is that the vast majority of non-acceptable PRs for a newly added repo will come from
people who are simply not known.
</p>
<p>
If it so happens that all of the problematic users can be added to the system or to the right
group, and that you have done so, then you can return to the PR details page and hit
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/so happens.*done so, then you can/all problematic users are added to the system and group,/

@@ -116,17 +107,17 @@
<h3>PR Details</h3>
<p>
If the PR is not in an acceptable state, this will list problematic users with a link to fix
them each. The fix can either be "Add to system" or "Edit" (details below).
them each, and alternatively a button to "Mark the PR as non-substantive".</p>
<p>For problematic users, the fix can either be "Add to system" or "Edit" (details below).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see matching comment

people who are simply not known, but that relatively quickly it ought to become a less
frequent occurrence.
The idea is that the vast majority of non-acceptable PRs for a newly added repo will come from
people who are simply not known.
</p>
<p>
If it so happens that all of the problematic users can be added to the system or to the right
group, and that you have done so, then you can return to the PR details page and hit
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see matching comment

@dontcallmedom dontcallmedom merged commit a911914 into master Apr 19, 2017
@tripu tripu deleted the repomanager-update branch May 3, 2017 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants