Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace jumpto.js with skipto.js version 4.2 #131

Merged
merged 24 commits into from Jun 23, 2022
Merged

replace jumpto.js with skipto.js version 4.2 #131

merged 24 commits into from Jun 23, 2022

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Jun 16, 2022

This pull request changes the code base from using JumpTo.js to SkipTo.js.

The 4.2 version of SkipTo.js has been updated to fix the following issues:

  1. Removing copyright code concerns by using the skipto.js script instead of the jumpto.js script, see SkipTo copyright statement in code.
  2. Selection of main landmark option on the home page, by insuring focus moves to a visible element.
  3. The Skip To menu button labeling issue (e..g. "opton" is now pronounced instead of "command" on macOS).
  4. The skipto menu of options will now scroll if the number of items exceeds the size of the window to display them all.

@netlify
Copy link

netlify bot commented Jun 16, 2022

Deploy Preview for wai-aria-practices2 ready!

Name Link
🔨 Latest commit f83e9ef
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria-practices2/deploys/62b4b82df4f06a0009bf396c
😎 Deploy Preview https://deploy-preview-131--wai-aria-practices2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@richnoah
Copy link

@jongund we are in the process of getting ready for a coordinated deploy with WAI on the morning of 6/24. We will review this PR again and merge it in. Please refrain from making any other commits so I can make sure all is in good order for the deploy.

package-lock.json Outdated Show resolved Hide resolved
@mcking65
Copy link
Contributor

@richnoah Idon't concur with latest changes by Jon; I need to fix the license/copyright to be what is appropriate based on agreement with skipto.

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all; this is good to ship now. I will merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants