Skip to content

Commit

Permalink
Thou shalt not alter the form’s role
Browse files Browse the repository at this point in the history
See w3c/aria#85 (It’s complicated)

Also, the search input missed an id attribute.
  • Loading branch information
yatil committed Sep 11, 2015
1 parent ddb68e0 commit 338821d
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions source/developing.html.erb.md
Expand Up @@ -135,11 +135,13 @@ Use appropriate mark-up for headings, lists, tables, etc. HTML5 provides additio
<div class="mark-up">
<figure>
<% html_example do %>
<form action="" role="search">
<label for="search">Search</label>
<input type="search" aria-describedby="search-help">
<div id="search-help">Search records by customer id or name</div>
<button type="submit">Go</button>
<form action="">
<div role="search">
<label for="search">Search</label>
<input type="search" id="search" aria-describedby="search-help">
<div id="search-help">Search records by customer id or name</div>
<button type="submit">Go</button>
</div>
</form>
<% end %>
</figure>
Expand Down Expand Up @@ -493,4 +495,4 @@ These tips are only a part of web accessibility. The following resources will he

{::nomarkdown}
<%= tip :end %>
{:/}
{:/}

0 comments on commit 338821d

Please sign in to comment.