Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code snippet colors against background #45

Closed
haltersweb opened this issue Jan 27, 2017 · 4 comments
Closed

Code snippet colors against background #45

haltersweb opened this issue Jan 27, 2017 · 4 comments

Comments

@haltersweb
Copy link
Member

Using code snippet syntax coloring is very important. I'm so glad to see it here.

But the different syntax colors might cause contrast problems against the gray.

You could test all the colors, but...

...another option would be to have a button at every code snippet that changes it to black and white. That way you can maintain the semantic color that developers are used to while solving for low vision.

@bakkenb
Copy link

bakkenb commented Jan 30, 2017

I like the option that Adina is suggesting (if it is not to difficult or time consuming to incorporate. Also as long as it does not add to the clutter or complexity of the pages. Giving people these choices are good, but I don't want to sacrifice our streamlined look and feel or add too much complexity to the site.

@yatil
Copy link
Contributor

yatil commented Jan 31, 2017

I agree. Also it is not to much of an hassle to test the colors and make sure they all conform.

@lakeen
Copy link

lakeen commented Jan 31, 2017

I vote for testing the colors to keep it simple. We're only talking about 3-4 tests.

@James-Green
Copy link

Resolution: Eric and Caleb will put the prototype together and Alicia will review the colors that come out. No button to switch to black and white, we'll pick a palette that passes AA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants