Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header/Navigation Proposal #34

Closed
yatil opened this issue Apr 13, 2018 · 10 comments
Closed

Header/Navigation Proposal #34

yatil opened this issue Apr 13, 2018 · 10 comments
Assignees

Comments

@yatil
Copy link
Contributor

yatil commented Apr 13, 2018

The following is the proposal that @slhenry, Sarah Pulis and I worked on during the Face-to-Face meeting in San Diego in March 2018. Here’s my understanding of what we want to do:

Remove Drop Down Menu

Reason: The drop down does not work well with the site's content – some main categories have only a few items, others have many. The menu has been hard to use, and different users have different assumptions on how a menu like this should work (See discussion in #14).

Approach: Remove the drop-down and instead use left navigation that has all links to the current category. Click on an item to reveal sub-pages of that page.

Change would address/resolve the following issues:

Visual changes

  1. Fix claim position (closer to “logo”)
  2. Change uppercase “About WAI” & “Get Involved” to lower case (Use of uppercase letters for link text in header #23, Header Design feedback #33)
  3. Change color behind navigation to a darker blue to make the navigation more visible (Navigation affordance #20, Header Design feedback #33)
  4. Work on spacing/padding (Header Design feedback #33)
  5. Adjust font sizes (Header Design feedback #33)
  6. Finesse responsive view of navigation (Header Design feedback #33)
  7. Increase tapable areas on the menu to meet WCAG 2.1 AAA for those items (Header Design feedback #33)

In-Progress Preview:

An in-progress version of those visual changes can be seen here:

Desktop breakpoint view

And here on “mobile”:

Mobile breakpoint view

@brewerj
Copy link

brewerj commented Apr 18, 2018

I think that this is a good proposal, especially given the plan (I think) to make the content currently available through the drop-down menus instead available through a left on-page nav. I would be sorry to lose the drop-down menus if there weren't a good alternative solution, as I think that the subheads are powerfully useful at communicating what kind of resources (aka buried treasures) exist on the website that many visitors otherwise won't know to look for. But I'm unclear from the "preview" version how this would work, so I want to make sure that I'm understanding your plan accurately. Are the left nav options supposed to be visible in the desktop preview above? (The mobile version makes sense visually, based on what I'm seeing in your proposal above, so this is a question only about the mobile version.)

@shawna-slh
Copy link
Collaborator

shawna-slh commented Apr 18, 2018

quick note so I don't forget: The thing we lose is being able to "walk the menus"...

@yatil
Copy link
Contributor Author

yatil commented Apr 18, 2018

  • change tagline separator to be centered between tagline and site name area

@yatil
Copy link
Contributor Author

yatil commented Apr 18, 2018

Shawn & I agree to go forward with the proposal for now.

yatil added a commit to w3c/wai-website-components that referenced this issue Apr 19, 2018
yatil added a commit to w3c/wai-website-components that referenced this issue Apr 19, 2018
yatil added a commit to w3c/wai-website-components that referenced this issue Apr 19, 2018
yatil added a commit to w3c/wai-website-theme that referenced this issue Apr 19, 2018
@shawna-slh
Copy link
Collaborator

Seeing this in place now... with the darker blue on the nav, I think the overall effect is too dark. (related to w3c/wai-website-design#134)
Also, it doesn't make sense for the left side nav to have the lighter blue of the top part instead of the blue matching the nav -- thought I saw that somewhere, but maybe it it's being changed...

@yatil, let me know if you want to discuss this, or for me to provide color numbers...

@yatil
Copy link
Contributor Author

yatil commented Apr 25, 2018

Seeing this in place now... with the darker blue on the nav, I think the overall effect is too dark. (related to w3c/wai-website-design#134)

It looks very distinctive and professional. I really, really like it. The rest of the page is light and having a good contrast between header and content is good.

Also, it doesn't make sense for the left side nav to have the lighter blue of the top part instead of the blue matching the nav -- thought I saw that somewhere, but maybe it it's being changed...

I just built in the functionality. As we discussed previously the design and styling of the side navigation is about to change because we already had identified that it is too heavy in the current design. This was one of the feedback we got. I did not get to that yet.

@yatil, let me know if you want to discuss this, or for me to provide color numbers...

Colors to chose from: https://w3c.github.io/wai-website-components/components/detail/colors.html

@yatil
Copy link
Contributor Author

yatil commented Apr 25, 2018

Implemented most of the functionality, still open

  • Role of breadcrumb, do we need it? (Never got a clear answer to that question.)
  • Mobile menu is not showing the sub-menu right now, that needs to be fixed.
  • Mark current page and path

@yatil
Copy link
Contributor Author

yatil commented Apr 25, 2018

Seeing this in place now... with the darker blue on the nav, I think the overall effect is too dark. (related to w3c/wai-website-design#134)

It looks very distinctive and professional. I really, really like it. The rest of the page is light and having a good contrast between header and content is good.

Also when we had a lighter blue was criticized in #20 as the menu was not distinctive enough, which you marked as addressed with the change we have now.

@carmacleod
Copy link

Is there a link to see these changes? I tried https://w3c.github.io/wai-tutorials/ but that seems to still be old?

@yatil yatil mentioned this issue Apr 26, 2018
@yatil
Copy link
Contributor Author

yatil commented Apr 26, 2018

@carmacleod The preview can be found here: https://w3c.github.io/wai-website/

yatil added a commit to w3c/wai-website-components that referenced this issue Apr 27, 2018
Also lots of clean up and taking care of details

rel: w3c/wai-website#33
rel: w3c/wai-website#34
rel: w3c/wai-website#20
yatil added a commit to w3c/wai-website-components that referenced this issue Apr 27, 2018
@yatil yatil closed this as completed Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants