Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Aspects under test #274

Closed
wants to merge 6 commits into from
Closed

Conversation

moekraft
Copy link
Collaborator

@moekraft moekraft commented Sep 21, 2018

Incorporating editorial updates from Shadi and Anne along with feedback from ACT TF meeting, 9/20.


Preview | Diff

Incorporating editorial updates from Shadi and Anne along with feedback from ACT TF meeting, 9/20.
@moekraft
Copy link
Collaborator Author

@nitedog @annethyme Please review PR. I tried my best to capture all your feedback and the feedback from the group. Thanks, Moe

Anchor renamed. Fixing link.
Removing Test Definition link. Link instead to Applicability. I do not believe Expectations applies here.
@moekraft moekraft changed the title Editorial updates Updates to Aspects under test Sep 21, 2018
To separate requirement from descriptive information
@moekraft
Copy link
Collaborator Author

@WilcoFiers
Copy link
Collaborator

Thank you Moe. I've taken your changes and moved them into PR #273.

@moekraft
Copy link
Collaborator Author

Willco have incorporated these updates into his PR #273

@moekraft moekraft closed this Sep 24, 2018
WilcoFiers added a commit that referenced this pull request Sep 24, 2018
* Remove aspects MUST requirement #264

* Updated aspects based on feedback #257

* Make test cases required for all rules

* Change "local laws" to "laws" #231

* Add a paragraph on accessibility of rules #226

* Rewrote benchmark to non-normative section #236 #239 #163

* Consistency in rule-aggregation #266

* Tweaked accessibility support language #221

* Changed test subject from MUST to MAY #220

* Require rule IDs in atomic rules list #261

* Fix rule type example #230

* Add rule type to the rule structure #232

* Update from #274

* Add "satify" explanation for Rules to SCs. #227

* Example to "satisfy" WCAG SCs #250

* Scrub document to ensure correct use of "should" and "may" #267

* Break up the PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants