-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Aspects under test #274
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorporating editorial updates from Shadi and Anne along with feedback from ACT TF meeting, 9/20.
@nitedog @annethyme Please review PR. I tried my best to capture all your feedback and the feedback from the group. Thanks, Moe |
Anchor renamed. Fixing link.
Removing Test Definition link. Link instead to Applicability. I do not believe Expectations applies here.
To separate requirement from descriptive information
This was referenced Sep 21, 2018
Thank you Moe. I've taken your changes and moved them into PR #273. |
Willco have incorporated these updates into his PR #273 |
WilcoFiers
added a commit
that referenced
this pull request
Sep 24, 2018
* Remove aspects MUST requirement #264 * Updated aspects based on feedback #257 * Make test cases required for all rules * Change "local laws" to "laws" #231 * Add a paragraph on accessibility of rules #226 * Rewrote benchmark to non-normative section #236 #239 #163 * Consistency in rule-aggregation #266 * Tweaked accessibility support language #221 * Changed test subject from MUST to MAY #220 * Require rule IDs in atomic rules list #261 * Fix rule type example #230 * Add rule type to the rule structure #232 * Update from #274 * Add "satify" explanation for Rules to SCs. #227 * Example to "satisfy" WCAG SCs #250 * Scrub document to ensure correct use of "should" and "may" #267 * Break up the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporating editorial updates from Shadi and Anne along with feedback from ACT TF meeting, 9/20.
Preview | Diff