Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about language #521

Merged
merged 3 commits into from Oct 28, 2021
Merged

Add note about language #521

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b629d0
Add note about language
Jym77 Sep 29, 2021
d9c14ef
Restrict bit about understanding language to some rules.
Jym77 Oct 15, 2021
cf20981
Streamline text
Jym77 Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions NOTE-act-rules-common-aspects.bs
View file
Open in desktop
Expand Up @@ -65,3 +65,5 @@ Language {#input-aspects-text}
Language, either written or spoken, contained in nodes of the DOM [[DOM]] or accessibility trees may be of interest to ACT Rules that intend to test things like complexity or intention of the language. For example, an ACT Rule might test that paragraphs of text within the DOM tree do not exceed a certain readability score or that the text alternative of an image provides a sufficient description.

The means by which the language is assessed, whether by a person or a machine, is not of importance as long as the assessment meets the criteria defined in [[wcag2-tech-req#humantestable]] [[WCAG]].

Rules with a Language input aspect can only be evaluated if the language can be determined (either programatically or by analysing content), and sufficiently understood.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Rules with a Language input aspect can only be evaluated if the language can be determined (either programatically or by analysing content), and sufficiently understood.
Rules with a language input aspect can only be processed if the language can be determined, either programatically or by reading the content.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 The bit about "fully understood" comes from the current assumption in the rules and was here from the start (in act-rules/act-rules.github.io#996) The core reason being that in order to evaluate, say, "heading is descriptive", one doesn't only need to determine that the language is French, but also to actually understand it.

However, I am having trouble tracking down in details the discussions about that point 🙈 The formulation was suggested by Emma (act-rules/act-rules.github.io#996 (comment)) at which point I disagreed (act-rules/act-rules.github.io#996 (comment)) but it seems that the next answered convinced me because I ended up making that change (act-rules/act-rules.github.io@8add94d).

So, I'm not any more fully sure whether this bit is needed or not, but I wouldn't want to remove it as part of a "streamlining" PR of moving assumptions from one place to another.