Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nav bar bug -- adjust pager css #27

Closed
wants to merge 6 commits into from
Closed

nav bar bug -- adjust pager css #27

wants to merge 6 commits into from

Conversation

SteveALee
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Aug 25, 2022

Deploy Preview for wai-wcag-redesign ready!

Name Link
🔨 Latest commit 5d8c2b7
🔍 Latest deploy log https://app.netlify.com/sites/wai-wcag-redesign/deploys/6310b5290c6e5300088b40c1
😎 Deploy Preview https://deploy-preview-27--wai-wcag-redesign.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@SteveALee
Copy link
Contributor Author

SteveALee commented Aug 25, 2022

@michael-n-cooper I noticed a couple of other possible issues

  • the current guideline in the pager was highlighted as if it is a tab. needed to remove the active state,
  • techniques pager doesn't seem to be working at all

@SteveALee SteveALee mentioned this pull request Aug 25, 2022
@shawna-slh shawna-slh changed the title Adjust pager css. Addressess #2 nav bar bug -- adjust pager css Aug 25, 2022
@shawna-slh
Copy link
Contributor

shawna-slh commented Aug 25, 2022

Hey @SteveALee I can't tell if there are still open issues, or if this is ready for Michael?

From my quick QA, the pager now gets the scrollbar when need on all the Understanding pages.

In issue 2 you said:

I saw the scrollbar whenever hover ove the pager so suspect a width bug somewhere

I haven't been able to reproduce that in Vivaldi or Firefox. Is it fixed or still an issue? If still an issue, would you be comfortable with that being milestone level 4 that we might not get done before roll out?

from above:

techniques pager doesn't seem to be working at all

We decided not to implement a "pager" in the techniques, since users pretty much never "walk" the techniques. So for now that area has only "All Techniques". For later enhancement we might add the categories, but that is very low priority for later.

the current guideline in the pager was highlighted as if it is a tab. needed to remove the active state,

looks to me like you go that fixed!?!

If good to go, please comment so, and re-assign to Michael. Thanks!

@shawna-slh shawna-slh added the bug Something isn't working label Aug 25, 2022
@SteveALee
Copy link
Contributor Author

Left assigned to me due to scrollbar issue I saw. But as you cannot repo I'm good.

I'd did a global fix for pager highlight, even though not strictly required as I left details for fix in source.

Assigning over to Michael.

@SteveALee
Copy link
Contributor Author

Oops github mobile app doesn't let me assign

@michael-n-cooper sorry for large difference due to "active" change. Hopefully you can do a different from before.

@shawna-slh shawna-slh marked this pull request as ready for review December 13, 2022 17:54
@shawna-slh shawna-slh closed this Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants