Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video on "Understanding SC 1.4.10" page fails SC 1.4.10 #3793

Closed
front-endian opened this issue Apr 22, 2024 · 6 comments · Fixed by #3794
Closed

Video on "Understanding SC 1.4.10" page fails SC 1.4.10 #3793

front-endian opened this issue Apr 22, 2024 · 6 comments · Fixed by #3794

Comments

@front-endian
Copy link

On the Understanding SC 1.4.10 the video showing the BBC website scaling for smaller screen widths doesn't scale with the width of the page. You to need to do horizontal scrolling to see the rest of the video and video controls on windows smaller than about 2,300px wide (at least on Chrome 123.0.6312.124 on MacOS).

It looks like this can be fixed by giving width:100% to the <video> element itself. I could put up a PR with that change, but I am not sure if y'all want to do a more wholistic fix as the same issue may also be present on other videos on other W3C/WCAG pages.

@patrickhlauke
Copy link
Member

duplicate, and supposedly fixed by #3115 but problem still there. @iadawn any idea what's going on?

@iadawn
Copy link
Contributor

iadawn commented Apr 23, 2024

Missed your follow up comment on the typo 'examples' rather than 'example'. Will raise PR to fix that.

iadawn added a commit that referenced this issue Apr 23, 2024
iadawn added a commit that referenced this issue Apr 23, 2024
@iadawn
Copy link
Contributor

iadawn commented Apr 23, 2024

Ignore my PR. @patrickhlauke you are paying better attention to detail than me. More ☕️ needed

@patrickhlauke
Copy link
Member

no worries @iadawn :)

@patrickhlauke
Copy link
Member

just documented/commented on that PR of yours, but not to tell you off, just for context/posterity :)

@iadawn
Copy link
Contributor

iadawn commented Apr 23, 2024

Posterity will forever judge me harshly ;)

mbgower pushed a commit that referenced this issue May 28, 2024
Follow-up to #3115

Closes #3793 (and all the previous
issues about this, the fix in #3115 seems to have been
partial/incorrect)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants