Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technique pages headings and landmarks could be improved #3859

Open
fstrr opened this issue May 13, 2024 · 1 comment
Open

Technique pages headings and landmarks could be improved #3859

fstrr opened this issue May 13, 2024 · 1 comment

Comments

@fstrr
Copy link
Contributor

fstrr commented May 13, 2024

The landmarks and headings on Techniques pages (e.g., ARIA1), could be improved.

Currently, the sidebar table of contents has two nested, unlabeled nav elements and the "page contents" heading isn't marked up as an Hn element. Similarly, the "about this technique" aside landmark has a heading not marked up as Hn element.

It would be good to:

  1. Mark up "About this technique" and "Page Contents" headings as Hn elements.
  2. Remove one of the nav elements from the table of contents and label the remaining one (ref: ARIA11).
@iadawn
Copy link
Contributor

iadawn commented Jun 6, 2024

@fstrr For the heading levels, "About this technique" is easy enough. "Page contents" however, is a bit of a pain. In the DOM it is above the H1 on the page so ideally it should be an H1 itself. That work for you? If not, then there is a bit of work to rearrange things on the page.

Alternatively, I could just put an aria-label on it?

iadawn added a commit that referenced this issue Jun 6, 2024
Changing `<header>` to `<h2>` for Guideline, Success Criterion and Technique boxes
iadawn added a commit that referenced this issue Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants