Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCAG 2.2 Pointer Target Spacing #1179

Merged
merged 32 commits into from Jul 21, 2020
Merged

WCAG 2.2 Pointer Target Spacing #1179

merged 32 commits into from Jul 21, 2020

Commits on Jun 15, 2020

  1. Configuration menu
    Copy the full SHA
    e9fb5cd View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. Configuration menu
    Copy the full SHA
    064bca6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0f1ba73 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a2bb34e View commit details
    Browse the repository at this point in the history
  4. add id to figure

    Michael Cooper committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    0c43268 View commit details
    Browse the repository at this point in the history
  5. add id to figure in understanding

    Michael Cooper committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    f054071 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. Tackling questions by JAWS-test

    Addressing #1179 (comment)
    The points are addressed in a new section, "Scope and applicability"
    Also updating the second paragraph in section "Intent of Pointer Target Spacing" to make it easier to understand (or so I hope).
    detlevhfischer committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    6e042ef View commit details
    Browse the repository at this point in the history
  2. minor correction

    detlevhfischer committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    914d2d8 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. Modified the bit on native targets

    Took out the bit that the SC applies to the spacing between native elements (I think it that is clear), but addressing @JAWS-test's comments, added an exception for the spacing of targets _inside_ unstyled native elements (i.e. where the vertical spacing of options in a select is determined by the default browser behaviour).
    detlevhfischer committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    33a9049 View commit details
    Browse the repository at this point in the history
  2. removed mention of touch

    Following comments by @patrickhlauke I removed mention of touch in two places.
    detlevhfischer committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    f2afbe4 View commit details
    Browse the repository at this point in the history
  3. Edit of figcaption, examples

    Added a third example (row of buttons with sufficient spacing above and below).
    Edited the figcation / legend of thee image with the three differnet positionings of the magnify icon over a profile image, reduced length of the alt attribute.
    detlevhfischer committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    2598fc1 View commit details
    Browse the repository at this point in the history
  4. Criteria > criterion, section on adapation

    @patrickhlauke Changed criteria to criterion where needed
    Changed some of the figaption text to make them easier to understand
    Changed an odd sentence above the profile images /maginfication icons illustiration
    Changed the paragraph above h2 Benefits (pointing out the benefits of general adaptability of size/spacing)
    Added a third example in second position (row of buttons where enough vertical spacing is present to meet SC)
    detlevhfischer committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    c403203 View commit details
    Browse the repository at this point in the history
  5. Improving image legends

    I improved the ficaption legends of the illustration, some were hard to understand.
    I improved the image legends / figcaption texts, and removed the heading Scope and applicability, would have needed a further subheading to separate what are essentialy examples with illustrations. It is odd that there is an actual section Examples further down whithout illustrations, but I do not want to carry through a complete overhaul of the Understanding page at this point. I think it would generally be benefitial to have more subheadings in the longier understanding pages, not just Intent / Benefits / examples, but I am not sure how flexible we are in this respect...
    detlevhfischer committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    3cf7ebf View commit details
    Browse the repository at this point in the history
  6. minor edits

    detlevhfischer committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    8393a07 View commit details
    Browse the repository at this point in the history
  7. minor edits to legend

    detlevhfischer committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    9968230 View commit details
    Browse the repository at this point in the history
  8. minor edits

    detlevhfischer committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    78b316e View commit details
    Browse the repository at this point in the history
  9. minor edits in legends

    detlevhfischer committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    46b5681 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    dba96a6 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    72bd145 View commit details
    Browse the repository at this point in the history
  12. minor edit

    detlevhfischer committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    56d7447 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. Configuration menu
    Copy the full SHA
    fd72e01 View commit details
    Browse the repository at this point in the history
  2. Added exception.

    alastc committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    9fca895 View commit details
    Browse the repository at this point in the history
  3. Corrrecting punctuation.

    alastc committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    c770d73 View commit details
    Browse the repository at this point in the history
  4. Removing extra key-terms item

    alastc committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    1fe18b5 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Configuration menu
    Copy the full SHA
    4cdc3eb View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2020

  1. corrected typo minumum

    detlevhfischer committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    1fcbc94 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    94843d1 View commit details
    Browse the repository at this point in the history
  3. Minor edits

    Changed to "or must be placed at the edge"
    Accepted "to make sure that there is sufficient adjacent spacing in each dimension"
    Changed to "and a magnifying glass"
    Changed "excempted" -> exempted
    detlevhfischer committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    00df37d View commit details
    Browse the repository at this point in the history
  4. Added intro sentence in section benefits

    Slightly changed wording:  "Having targets with sufficient target spacing can help all users who may have difficulty in confidently targeting or operating small controls. Users who benefit include, but are not limited to:"
    detlevhfischer committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    78fa9d7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    128c97e View commit details
    Browse the repository at this point in the history
  6. Udate of name of sufficient Technique

    Updated name to "Using min-height and min-width to ensure sufficient target spacing"
    detlevhfischer committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    3e4dbd0 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. Prepping for merge

    alastc committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    4a7ed23 View commit details
    Browse the repository at this point in the history