Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates from issue 291 #1269

Merged
merged 9 commits into from
May 18, 2023
Merged

Updates from issue 291 #1269

merged 9 commits into from
May 18, 2023

Conversation

alastc
Copy link
Contributor

@alastc alastc commented Aug 8, 2020

Closes #291

@alastc alastc mentioned this pull request Aug 8, 2020
Closed
@carmacleod
Copy link
Contributor

carmacleod commented Aug 9, 2020 •
edited

Looks good! Thank-you! Just the one comment/question about HTML vs HTML5. :)
(Also - just curious! - what does the "Survey - Ready for" label mean?)

carmacleod
carmacleod approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@carmacleod carmacleod left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR, whether or not HTML5 is changed to HTML (because that's a whole other issue, and it's unrelated to this change).

[Edit: just added one more "github suggestion" to change "a label" to "an accessible label" so that it isn't confused with "a <label>"].

Thanks, @alastc !

@carmacleod carmacleod mentioned this pull request Aug 14, 2020
Open
@carmacleod
Copy link
Contributor

@alastc
This is so close!
What else needs to happen before it can be merged?
Does it need another reviewer?
Thanks!

@alastc
Copy link
Contributor Author

alastc commented Nov 2, 2020

Hi @carmacleod, "Survey ready" means it is in the queue to be discussed/approved at a meeting.

Our focus is on WCAG 2.2 issues at the moment though, so it might be a little while.

Base automatically changed from master to main March 5, 2021 20:42
@mbgower @carmacleod
Update techniques/aria/ARIA11.html
526b1a4 
Co-authored-by: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
@mbgower
Copy link
Contributor

mbgower commented Nov 9, 2021

@alastc this is a likely candidate to add to our Dec 3 omnibus call, if it isn't reached sooner

@mbgower
Copy link
Contributor

mbgower commented Nov 9, 2021

  • region: A region of content for an author-specific purpose that is important for users to be able to navigate to. It maps to section in HTML5, and needs an accessible label to be included as a landmark for assistive technology.

    • HTML maps to ARIA roles, not the other way around. Adding some rewording to address this, and clarify when a label is required.

    @mbgower
    Update ARIA11.html
    ff70689 
    Attempt to better address the relationship between region and html5 section
    @mbgower
    Update ARIA11.html
    a108fa7 
    altered form by accident. moving update to the region list item
    @mbgower
    Update ARIA11.html
    d60fb14 
    fixed another glitch with my change
    @carmacleod
    Copy link
    Contributor

    As of ARIA 1.2 (March 2, 2021), form has the same "accessible label" requirement now as region/section. Maybe we can reuse some of the region words for form before this goes for review. See #291 (comment) and #1308.

    @alastc alastc merged commit bce6988 into main May 18, 2023
    1 check passed
    @alastc alastc deleted the aria11-add-region-role-291 branch May 18, 2023 11:26
    @alastc
    Copy link
    Contributor Author

    alastc commented May 18, 2023

    Approved: https://www.w3.org/2023/05/16-ag-minutes#item12

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @patrickhlauke patrickhlauke patrickhlauke left review comments

    @carmacleod carmacleod carmacleod approved these changes

    Assignees
    No one assigned
    Labels
    Techniques WCAG 2.0
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    ARIA11 should reference role="region", and not role="application"
    4 participants
    @alastc @carmacleod @mbgower @patrickhlauke