New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notes to 2.4.3 understanding #1643
base: main
Are you sure you want to change the base?
Conversation
a74545b
to
417b9ff
Compare
I'm a lot more concerned with redundant focus stops (i.e., press Tab and the focus does not appear to move) than I am on, say, focus moving to a non-interactive element. To the point where I'm a little concerned with this: "Redundant focus stops...are allowed..." If something is truly redundant, as in there is no change in focus (which is different than a link within a card you mention, IMO), I think that should not pass. Whereas, there are several situations where it may be necessary to put focus on a non-interactive component. Some may be needed to put the reading order there (think of a 'go to top' button), even a skip to main may require that (focus goes to region, for example). Think of a tablist; you want to put focus in a tab panel to allow screen reader consumption, even though there is no operable control in the tab panel.. The same thing can happen on a modal overlay in which nothing is operational (strictly informational). If focus isn't placed there, it may prevent a keyboard user from scrolling up and down in the content. So while I'm happy with almost all these changes, I would like to take out that explicit "it's okay" for redundant tab stops, but leave it in for non-operable elements. |
Not sure I follow what you mean exactly. Assuming it's something like it appears not to change, but practically does? Something silly like
perhaps? Would you say those fail 2.4.3 (I'd say generally they don't, but opinions may be split here)? And If so, how would you disallow this sort of thing / define it in a way that still allows for the non-problematic cases (card that contains a link)? That would probably require some hard definition of "redundant" (versus, say, "superfluous" or "unnecessary" or similar vague concepts) |
Even removing the wording around redundant, wouldn't something like
still not be understood as ok based on the rest of the note as well, based on the loose wording of
|
I think the example you provide of a div with a tabindex surrounding a button should be considered a failure of 2.4.3:
It's not a serious error, but it is confusing and disruptive to press a tab and have nothing happen. If I was testing a page and 2 tabstops occur on the same item, I'd ask that to be remediated, and if the answer came back "it's intentional", we'd be having a discussion on why. if we start putting language in saying such redundancy is 'okay', I think we need to be specific about what contexts it is okay. In the tile/link on tile example, if I understand what you are saying, two different focus indicators take place. Visually the focus has progressed as the user presses tab. So I wouldn't consider that a failure here. (I've seen examples where activating both may result in the same action, which I wouldn't call great design, but I think is orthogonal to Focus Order). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static content: "does not necessarily constitute a failure" and then: "These situations are only failures if they significantly impede the operation of the content". With focus stops on static content (e.g. all explanatory texts in a form) is remains a judgment call at what point this becomes a significant impediment. Which I believe is unavoidable - I'd call it not a "subjective" but a "context-dependent" aspect of conformance evaluation.
Would a few negative examples help to clarify what cases would be seen to fall under "significantly impede" and in turn, be cases to FAIL?
Oh, I like that, @detlevhfischer I was actually just about to have another go/tweak on this PR to possibly remove the explicit mention of "redundant" as it may have too much baggage/implication, as @mbgower pointed out above. I'd be all for more examples that clarify, but wonder if we'll be able to reach some kind of consensus (and make them representative enough, with enough context, to make it clear) |
Historically we've been quite strict on redundant tab-stops, on the basis that stopping twice on the same thing is confusing because you expect to go to the next thing. A common (ish) example is a listing on an ecommerce site and you stop once on each item which isn't active, press tab again and find the active tab-stop. It fits in with failing invisible/off-screen items under focus-visible. I'm not sure where I'd drawn the line if you had a couple of instances vs 20? |
I would argue that "a couple" is a still a failure of Focus Order -- it is just the degree of impact/severity that is affected. If I press on the same item many times with no apparent change in focus, that is more severe; some users will just abandon the site. If I have to press Tab twice on every single item to advance it, that is more severe, due to time on task, etc. |
@mbgower I would argue that (most?) screen reader users will have a good idea since if it is just a |
I've removed the explicit mention of "redundant" in this PR |
+1 to discussion as it stands. I am not disagreeing with anything, but I am taking the liberty to add one more anecdote. Adding tab stops to static content (in particular, instructions on forms) is something that mindful developers sometimes do on purpose (SSA is one example I think). I would not like for us to to come down hard on the practice. I agree with the updated note on this thread not to be permissive with redundant stops, as those can be very disorienting. |
understanding/20/focus-order.html
Outdated
@@ -63,6 +83,8 @@ <h2>Intent of Focus Order</h2> | |||
operability only when navigation sequences affect meaning and operability. | |||
</li> | |||
|
|||
<li>Focus order does not need to follow visual presentation or layout.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that I agree with this statement. The issue is that the interpretation of the visual presentation is subjective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does not necessarily need to follow visual presentation, perhaps? i've seen extreme cases where auditors gleefully fail things if they're not exactly in the same order as the visual, with things like three little icon-based buttons that receive focus right-to-left instead of left-to-right (because the author used CSS floats that effectively reversed the order) ... but where the meaning was not impacted and it was not really a problem.
there must be some way we can somehow make that clear...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, add "necessarily".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder if it's too handwavy though. maybe best to expand this, or add some more words that reflect what @awkawk rightly says...that it's subjective?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who is deciding what is the visual presentation order? Shouldn't the tab order follow whatever that is decided to be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or adding "as long as meaning/operation are not affected"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Who is deciding what is the visual presentation order?" not sure i follow...is this rhetorical? the author/designer will work on the visual/layout, but for various reasons the focus order may be slightly different. the point is that as long as meaning/operation aren't affected (and it's...subjectively...not too haphazard jumping all over the place) it's not necessarily a failure if the focus order doesn't strictly follow the western top-to-bottom/left-to-right (in left-to-right writing cultures)
We'll need to come back to this, some concern over what the 'visual order' would be, theres some assumptions in there. Can we adjust to avoid that? (See the minutes.) |
have they been published yet? |
@alastc @mbgower I've now read over the minutes, but they're...cryptic. not quite sure how to proceed here. bone of contention seems to be a disagreement around the "focus order doesn't necessarily need to match the visual order". would it be clearer if it said "visual layout" ? basically, I contend that if you have, say, three buttons on the page, and they receive focus right-to-left instead of left-to-right, but meaning/operation is unaffected by this, then that's kosher. i've seen too many auditors fail this sort of scenario under the "in western culture we go left to right, so your buttons are wrong" guise...which I would strongly push back against (depending on scenario here of course) as nobody's really affected by this sort of thing (again, depends on the exact layout we're talking about) and it's only busy-work to file this as a hard failure of the SC. and yes, bigger cases/examples, visually a navigation sidebar on the left, but it receives focus after all the main content. i remember this used to be one of those arguments back in the day, with people on both sides claiming "it's better for the user if nav comes first" / "it's better for the user if it comes last", both with the same sense of entitled authority when making that claim... best practice sure, follow top-to-bottom/left-to-right (for cultures using that reading convention), but not failing sites where the focus order diverges, but still makes sense/meaning is not lost because of it. |
@patrickhlauke part of the discussion was that this specific part of the fix doesn't seem to be related to the issues that were raised, which was about non-interactive items in the tab order. There was discussion that there was an additional issue that was related, but no one knew what it was. |
quite possibly, but since I was already working on the 2.4.3 understanding, I opted to also add wording to cover that aspect (which I encounter constantly in discussions) without first filing an issue. so what's the idea? make this only about the two issues, and then file another issue for this other aspect and wait another (looks at the timestamp on this PR... Feb 2021...) 3.5 years until we get around to addressing THAT? |
digging through the issue, I believe that originally (back in Feb 2021) the PR was more focused on just those two referenced issues. as we started wordsmithing and expanding things here, the additional more general "doesn't necessarily have to match layout" part came in as well (around the time of #1643 (comment) perhaps) |
Suggestions for the PR: Line 70-76: I agree with the text content, but I’m not sure about the example. I am certainly not going to advocate for links in buttons (or the inverse) but I’m also not sure how to rationalize failing it. The strongest argument is that users may focus an item that can’t be actioned by the user, but of course that is what we are allowing with the setting of focus on non-interactive elements also… I think that we need a different example. Line 86: |
Made a few tweaks/changes to try and disambiguate things a bit more:
|
8494613
to
d841c2a
Compare
A bit more explanation of what I heard in the discussion. There was some confusion over the lack of division between reading order and focus order, and the 2-column example seemed to enforce that. |
that would be a clear failure. my point was that there are cases where it's fine to go right-hand column first, the left-hand column. for instance, left-hand is navigation, right-hand is content, but the author decided that focus goes through the content first, and THEN the navigation. would that example work? |
it would be nice to get this considered at some point ... |
The TF was generally approving of this PR, just thought the sentences on lines 79-82 could do with a little tweak, @giacomo-petri will have a go. |
then we want to make damned sure we cover all possible acceptable cases, because otherwise by implication we're saying that anything not covered there will automatically FAIL the criterion
in terms of focusable and receiving programmatic focus, I would hope that you're at least suggesting that it's kosher to set programmatic focus anywhere the author deems necessary, at least |
Closes #1572
Closes #2655
In short, this touches on aspects of focus order that have always been a bit... "sketchy"/handwaved: