Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the contrast value #1780

Merged
merged 5 commits into from Jun 10, 2021
Merged

Updating the contrast value #1780

merged 5 commits into from Jun 10, 2021

Conversation

alastc
Copy link
Contributor

@alastc alastc commented May 4, 2021

Closes #360, closes #1213

@mraccess77
Copy link

I'd assert that it has no impact on the calculation. The value falls between 10/255 and 11/255 which falls outside of the values that are set below and above each version and thus the calculated values that could exist are not impacted by this change at all.

@patrickhlauke
Copy link
Member

I'd assert that it has no impact on the calculation. The value falls between 10/255 and 11/255 which falls outside of the values that are set below and above each version and thus the calculated values that could exist are not impacted by this change at all.

not worried about end results being different. more in terms of somebody digging into the source code of a tool and being left baffled why that tool may have used that other value / why that particular value.

@bruce-usab
Copy link
Contributor

bruce-usab commented May 5, 2021

I agree with the logic of mentioning the old value. But please delete should from the explanation.

@mraccess77
Copy link

I agree on removing "should". Both values will work and either can be used to meet the requirement as they provide the same result.

@alastc
Copy link
Contributor Author

alastc commented May 11, 2021

All the changes were included and agreed today.

@michael-n-cooper I've removed the references to the old sRGB standard. Anywhere we used it was in conjunction with the other one, which is the more up to date version. Does removing it from the json file and removing the instances of [[srgb]] do the job?

@awkawk awkawk added the ErratumRaised Potential erratum for a Recommendation label May 13, 2021
From AWK comment.
@alastc
Copy link
Contributor Author

alastc commented Jun 10, 2021

@alastc alastc merged commit 640b650 into main Jun 10, 2021
@alastc alastc deleted the Issue1213-contrast-variable branch June 10, 2021 18:44
mbrambilla added a commit to cast-org/figuration that referenced this pull request Nov 4, 2021
Use the corrected value being included in WCAG 2.2 spec - Reference: w3c/wcag#1780
As stated in the update that there should be "no practical effect on the calculations" - as can be seen by the minor adjustments in precision
mbrambilla added a commit to cast-org/figuration that referenced this pull request Nov 4, 2021
Use the corrected value being included in WCAG 2.2 spec - Reference: w3c/wcag#1780
As stated in the update that there should be "no practical effect on the calculations" - as can be seen by the minor adjustments in precision
michael-n-cooper pushed a commit that referenced this pull request Feb 22, 2022
* Updating the contrast value

* Rain's suggested wording

* removing the SRGB reference

@michaelc does this work for removing a bib entry?

* Meeting updates.

* Aligned understandings docs

From AWK comment.
patrickhlauke added a commit to twbs/bootstrap that referenced this pull request Dec 27, 2022
patrickhlauke added a commit to twbs/bootstrap that referenced this pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ErratumRaised Potential erratum for a Recommendation WCAG 2.0 WCAG 2.1 WCAG 2.2
Projects
None yet
5 participants