Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarifying name, role, value #2207

Merged
merged 8 commits into from
Feb 13, 2024
Merged

clarifying name, role, value #2207

merged 8 commits into from
Feb 13, 2024

Conversation

scottaohara
Copy link
Member

closes #2142

In an attempt to add clarity that it's not just that a name, role and value are exposed but the correct name role and value are exposed, I have simply added the word "accurate" to two sentences. This will help imply that it's not just "information" that needs to be exposed to AT, but "accurate information" about what the control represents.

If more modifications are necessary here, please let me know and I can make those changes, or the editors can make changes as they see fit.

closes w3c#2142

In an attempt to add clarity that it's not just that a name, role and value are exposed but the **correct** name role and value are exposed, I have simply added the word "accurate" to two sentences.  This will help imply that it's not just "information" that needs to be exposed to AT, but "accurate information" about what the control represents.

If more modifications are necessary here, please let me know and I can make those changes, or the editors can make changes as they see fit.
largely pulling in [Alastair's new paragraph suggestion](w3c#2142 (comment)), but I modified it a bit to try and use language similar to what ARIA and HTML use (e.g., what the control **represents** dictates its intended semantics and thus the important accessibility information that would be appropriate to convey).

Also, noticed the use of the word "must" in a note in this informative document.  so, changed that to "needs to" to keep the intent.
Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would correct be better than appropriate?

@patrickhlauke
Copy link
Member

"correct" implies that there's a binary "right/wrong". "appropriate" allows for there to be a certain level of ambiguity, a sliding scale of appropriateness. the latter better matches reality

@bruce-usab
Copy link
Contributor

bruce-usab commented Sep 29, 2022

"correct" implies that there's a binary "right/wrong". "appropriate" allows for there to be a certain level of ambiguity...

Agreed. I am okay with appropriate. I would prefer not incorrect but that is almost a double negative.

@scottaohara
Copy link
Member Author

@bruce-usab @alastc could this be added to the next survey, or for the 2.x sub-group to determine if it's good to merge?

@patrickhlauke patrickhlauke self-requested a review December 8, 2023 16:49
Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tiny suggested tweaks/additions - see code comments

scottaohara and others added 2 commits December 22, 2023 17:53
Co-authored-by: Patrick H. Lauke <redux@splintered.co.uk>
Co-authored-by: Patrick H. Lauke <redux@splintered.co.uk>
@scottaohara
Copy link
Member Author

@patrickhlauke per our discussion today, can you either:
1 update the PR with the changes you think are needed
2 approve this PR and then we'll make a follow-on

Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good to me! Thank you @scottaohara and @patrickhlauke

@scottaohara
Copy link
Member Author

last thing to do here is to add a link to the definition of a11y supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

does a control that exposes an incorrect/inappropriate role fail 4.1.2 or not
6 participants