Technique G183: expand example 2 to actually illustrate the technique's point #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd8
reviewed
Mar 2, 2022
dd8
approved these changes
Mar 2, 2022
#2240 will address the location of the relative luminance file |
|
Confirming that the problem with the relative link I mentioned seems to be fixed in https://www.w3.org/WAI/WCAG22/Techniques/general/G183 |
alastc
reviewed
May 3, 2024
Co-authored-by: Alastair Campbell <ac@alastc.com>
bruce-usab
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2243
Note that, in addition, the links to the glossary definition
<a>relative luminance</a>are broken / not correctly converted https://www.w3.org/WAI/WCAG21/Techniques/general/G183 - they just end up pointing to https://www.w3.org/TR/WCAG21/#However, I suspect this is an issue for @michael-n-cooper to look into (rather than trying to hardcode a url to the correct term definition https://www.w3.org/TR/WCAG21/#dfn-relative-luminance)