Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update H69 to address issue #1270 #2338

Merged
merged 2 commits into from
May 18, 2023
Merged

Update H69 to address issue #1270 #2338

merged 2 commits into from
May 18, 2023

Conversation

fstrr
Copy link
Contributor

@fstrr fstrr commented Apr 29, 2022

  • add reference to H97
  • make links more descriptive inline with other Technique documents

Closes #1270

- add reference to H97
- make links more descriptive inline with other Technique documents
@fstrr fstrr requested a review from alastc April 29, 2022 20:02
@patrickhlauke
Copy link
Member

@fstrr a heads-up: if you include Closes #XXXX in the first comment on the pull request, github will automagically tie the issue and PR together so when this is merged, it auto-closes the issue as well

Copy link
Contributor

@mbgower mbgower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-n-cooper i thought these complementary references were added automatically. Or is this a case where just because the list techniques cites the heading, it doesn't mean we need to have the heading citing the list technique? I do think that it's a weaker association going in this direction...

@alastc
Copy link
Contributor

alastc commented May 10, 2023

@fstrr could you check the "Resolve conflicts" on this PR please?

I assume the conflicts come from your technique updates, so you can probably spot which bits are new more easily than I can...

@fstrr
Copy link
Contributor Author

fstrr commented May 10, 2023

@alastc Tis done.

@alastc alastc merged commit 591abeb into main May 18, 2023
1 check passed
@alastc alastc deleted the fstrr-patch-3 branch May 18, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add H97 to related techniques for H69
4 participants