Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-title and update H63 (Using the scope attribute to associate header cells and data cells in data tables) #2515

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

fstrr
Copy link
Contributor

@fstrr fstrr commented Jun 6, 2022

Closes #2514

fstrr added 2 commits June 6, 2022 14:44
1. remove references to XHTML.
2. remove references to HTML 4.01.
3. remove references using the `scope` attribute on `td` elements, which isn't part of the HTML Living Standard anymore.
4. remove some questionable content on using the `scope` attribute where authors didn't use a th element because they don't like the way it looks or have used CSS to make the text bold instead.
5. Code example:
    1. change names so they’re not all male.
    2. remove border attribute on table.
    3. remove Fax column.
    4. Change “#” to “number”.
6. Fix broken links and typos.
7. Update Procedure:
    1. Change feels overly "wide" as it specifies "for each data table” rather than tables that need to use the `scope` attribute.
8. Update Resources links to point to Living Standard.
9. Marked up code as `code`.
10. Re-title document from “Using the scope attribute to associate header cells and data cells in data tables” to “Using the scope attribute to associate header cells with data cells in data tables”.
@detlevhfischer
Copy link
Contributor

detlevhfischer commented Jun 13, 2022

Her is a githack-rendered view of revised H63
Is the example complex enough to warrant the use of scope? Would it be better to have an example with nested headers or a header row that is not the first position?

@fstrr
Copy link
Contributor Author

fstrr commented Jun 13, 2022

"Would it be better to have an example with nested headers or a header row that is not the first position?"

Do you mean the row headers not being the first cell of each row? If so, they already aren't. For example:

<tr>
    <td>1.</td>
    <th scope="row">Charlotte Smith</th>
    <td>412-212-5421</td>
    <td>Pittsburgh</td>
  </tr>

If you don't mean that, can you maybe provide a code example? The table on that updated page is the same as the existing one, but with changes to people's names and I removed the "fax" column. That doesn't mean we can't update it further.

@detlevhfischer
Copy link
Contributor

@fstrr sorry, forget it, I didn‘t look closely enough. The example is fine!

@bruce-usab
Copy link
Contributor

Discussed on backlog call 10/27/2023.

@scottaohara scottaohara self-requested a review October 27, 2023 15:50
@mbgower
Copy link
Contributor

mbgower commented Nov 10, 2023

@alastc Neither @fstrr nor I can activate the Resolve conflicts button, which greyed out. Can you address?

@patrickhlauke
Copy link
Member

@alastc Neither @fstrr nor I can activate the Resolve conflicts button, which greyed out. Can you address?

that's a sign that the conflict is too complex to be resolved just by editing here on the web. you'd need to resolve it on a computer (switching to the branch, editing the files in conflict, committing, then pushing again to the branch)

techniques/html/H63.html Outdated Show resolved Hide resolved
Co-authored-by: Mary Jo Mueller <maryjom@us.ibm.com>
@mbgower mbgower merged commit 1323e3d into main Jan 12, 2024
1 check passed
@mbgower mbgower deleted the issue-2514 branch January 15, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-title and update H63 (Using the scope attribute to associate header cells and data cells in data tables)
7 participants