Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update label-in-name.html #2725
Update label-in-name.html #2725
Changes from all commits
dbcd18a
0e3e259
d5329a3
1b7c0d5
bcaa80d
f90c61f
e877972
65ced68
fa3006a
6c31940
eaf0c9b
eacd3e5
c638219
d2c9f23
e40a7ff
0e8b2dc
bc66bd5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to list outliers to this? In the US, area codes for telephone numbers are sometimes shown within parentheses. Ex: (202)555-5555. The area code should be part of the name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kengdoj I think this use case falls under the "However, where parenthetical information provides important context, such as indication of a required field or limitations on what is allowed for input." I know how much easier it is top point developers to a line in a spec or documentation, but the possible number of cases that could be an outlier is potentially huge.
Also, I question any label that includes the formatting. That really should be aria-describedby information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this text increases understanding. Parenthetical information (relevant, but not necessary to understand), is probably better in the description than the label. Whether it is presented in parentheses (round brackets) or not seems more like a typographical accident.
I'm prone to putting a lot in parentheses. Some use commas and subsidiary clauses instead, others write more sentences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd agree with @nattarnoff that the example of the area code in parentheses doesn't seem to enter into the discussion on parentheses in a label. @kengdoj can you supply an example of an area code in a phone input label that would be problematic with the guidance listed in this subsection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chaals I entirely agree, but there's an unfortunate gap between what people should do and what they DO. As well as a gap between the intent of this SC and how it is being interpreted. Also, you'll note that the final advice in the section is that anything used parenthetically which affects input limitations needs to be surfaced programmatically -- with aria-describedby as a suggestion for how to incorporate.
Remember that we're discussing parentheses strictly in the context of input labels. These changes were introduced to address issues opened by users, and have support. In fact, this has already been voted on and approved by the WG.