Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 3.3.8 Accessible Authentication (add "(Minimum)") #3145

Merged
merged 17 commits into from
Jan 12, 2024

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Apr 11, 2023

I think this should cover all necessary changes to rename the SC. Also corrected a few minor errors/omissions in related understanding/techniques

See https://www.w3.org/2023/04/11-ag-minutes.html#resolution03

Closes #3087
Closes #3519


Preview | Diff

@patrickhlauke
Copy link
Member Author

apologies @cwadamsoforacle ... only just seen #3132 ... but I think this one's more complete/supersedes it

Copy link
Contributor

@rachaelbradley rachaelbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why we are seeing a dif for the wcag.json but otherwise these changes look good to merge.

@patrickhlauke
Copy link
Member Author

I am not sure why we are seeing a dif for the wcag.json

I manually updated it as part of this PR (as I was unclear how this is generated)

@patrickhlauke
Copy link
Member Author

@rachaelbradley assuming the .json thing is not a problem (cc @michael-n-cooper ?) do you mind merging this as well (unless this is controversial/touches on things it shouldn't)

@patrickhlauke
Copy link
Member Author

@rachaelbradley @michael-n-cooper I removed the wcag.json file from this PR (assuming this would get regenerated if there were substantive changes to names of SCs etc)

@alastc @mbgower any chance to get this looked at/merged? it patches a few minor things left over when 3.3.8 was made "Minimum"

@mbgower
Copy link
Contributor

mbgower commented Jul 4, 2023

I'm a little confused by this PR, to tell you the truth. I'm seeing the wording correct in the Understanding doc titles already.
I've made some basic comments on styling that can be applied to all documents, depending on the decision.

patrickhlauke and others added 2 commits July 4, 2023 17:28
Co-authored-by: Mike Gower <mikegower@gmail.com>
Co-authored-by: Mike Gower <mikegower@gmail.com>
@patrickhlauke
Copy link
Member Author

patrickhlauke commented Jul 4, 2023

@mbgower ok, it seems that <title> and <h2>s get ignored and modified by XSLT (presumably?) scripting when this gets actually published. not sure why the original files actually had them then (probably easier while doing reviews I guess?) - you can see those long headings etc in other understanding docs in the repo, even right back to the 2.0 days ... see https://github.com/w3c/wcag/blob/main/understanding/20/abbreviations.html

so for internal consistency, possibly worth carrying on with this weird tradition (despite it not actually doing anything for publication), which this PR does... or we start stripping the source understanding files for 2.0, 2.1, and 2.2 to shorten all the <h2>s and <h3>s altogether...

the changes to links and techniques should be valid though

@patrickhlauke
Copy link
Member Author

i'm less concerned about the <title> and <h2>/<h3> changes here (though for consistency it would be good if they were right), and more about the links that currently don't include the right/correct wording

@patrickhlauke
Copy link
Member Author

ping once more, as currently there's some blatantly broken links (like the first one in https://www.w3.org/WAI/WCAG22/Understanding/accessible-authentication-enhanced.html#examples)

@fstrr
Copy link
Contributor

fstrr commented Oct 15, 2023

I mentioned a couple of your typo PRs from 2022, a PR I have that, coincidentally, has the same fix in as this, and some other typo PRs in last Friday's backlog meeting. I'm hoping that'll get those merged in.

there's no order to them (and other understanding docs use unordered lists here too)
Just making this grammatical with terminal punctuation, since it is an independent clause.
@mbgower
Copy link
Contributor

mbgower commented Oct 25, 2023

I've put this in the WCAG 2.x project with a draft status to be reviewed. Or @alastc maybe this has already been sufficiently reviewed?

@patrickhlauke
Copy link
Member Author

Would be great if this could be merged soon (before it diverges more from main changes), as currently we have 404 links (see #3519)

@bruce-usab bruce-usab self-assigned this Dec 8, 2023
Co-authored-by: Mary Jo Mueller <maryjom@us.ibm.com>
@mbgower mbgower merged commit 0fc9e32 into main Jan 12, 2024
1 check passed
@mbgower mbgower deleted the patrickhlauke-issue3087 branch January 15, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants