-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename 3.3.8 Accessible Authentication (add "(Minimum)") #3145
Conversation
apologies @cwadamsoforacle ... only just seen #3132 ... but I think this one's more complete/supersedes it |
071a0a5
to
b91cf72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure why we are seeing a dif for the wcag.json but otherwise these changes look good to merge.
I manually updated it as part of this PR (as I was unclear how this is generated) |
@rachaelbradley assuming the |
…into patrickhlauke-issue3087
@rachaelbradley @michael-n-cooper I removed the @alastc @mbgower any chance to get this looked at/merged? it patches a few minor things left over when 3.3.8 was made "Minimum" |
I'm a little confused by this PR, to tell you the truth. I'm seeing the wording correct in the Understanding doc titles already. |
Co-authored-by: Mike Gower <mikegower@gmail.com>
Co-authored-by: Mike Gower <mikegower@gmail.com>
@mbgower ok, it seems that so for internal consistency, possibly worth carrying on with this weird tradition (despite it not actually doing anything for publication), which this PR does... or we start stripping the source understanding files for 2.0, 2.1, and 2.2 to shorten all the the changes to links and techniques should be valid though |
i'm less concerned about the |
ping once more, as currently there's some blatantly broken links (like the first one in https://www.w3.org/WAI/WCAG22/Understanding/accessible-authentication-enhanced.html#examples) |
I mentioned a couple of your typo PRs from 2022, a PR I have that, coincidentally, has the same fix in as this, and some other typo PRs in last Friday's backlog meeting. I'm hoping that'll get those merged in. |
there's no order to them (and other understanding docs use unordered lists here too)
matching style in rest of document
Just making this grammatical with terminal punctuation, since it is an independent clause.
I've put this in the WCAG 2.x project with a draft status to be reviewed. Or @alastc maybe this has already been sufficiently reviewed? |
Would be great if this could be merged soon (before it diverges more from main changes), as currently we have 404 links (see #3519) |
…into patrickhlauke-issue3087
Co-authored-by: Mary Jo Mueller <maryjom@us.ibm.com>
I think this should cover all necessary changes to rename the SC. Also corrected a few minor errors/omissions in related understanding/techniques
See https://www.w3.org/2023/04/11-ag-minutes.html#resolution03
Closes #3087
Closes #3519
Preview | Diff