Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Understanding Focus Not Obscured #3163

Merged
merged 17 commits into from May 18, 2023
Merged

Conversation

bruce-usab
Copy link
Contributor

@bruce-usab bruce-usab commented Apr 28, 2023

Closes Issue #2809

WRT to diff — look at (Minimum) version first

  • Understanding Focus Not Obscured (Minimum) has relatively few changes as compared to the previous version.
  • Understanding Focus Not Obscured (Enhanced) started from (Minimum) version in this PR, so diff looks like a complete rewrite.

alastc and others added 6 commits May 5, 2023 16:30
Added two more (minimum) parentheticals and made examples a little less strict.
Added one more (Minimum) parenthetical, and softened intent.
Mostly copy/paste from recent work on Focus Not Obscured (Minimum)
Tweaking to allow more distinction between for (Enhanced) version.

Also, left out the word "focus" with previous edit.
Adjusting to make a little more distinct from focus not obscured (minimum)
@bruce-usab bruce-usab changed the title Update Understanding Focus Not Obscured (Minimum) Update Understanding Focus Not Obscured May 5, 2023
@bruce-usab
Copy link
Contributor Author

After backlog call 5/5, I noticed another place parenthetical needed.
I added (Enhanced) version to this PR.

@bruce-usab bruce-usab requested a review from mbgower May 5, 2023 21:55
@bruce-usab
Copy link
Contributor Author

Added @mbgower to review since he was feeling caught up.

Should (Enhanced) version be so tolerant of opaque overlay?

@bruce-usab
Copy link
Contributor Author

Edit to (Enhanced) version after AGWG call 5/9.

@mbgower
Copy link
Contributor

mbgower commented May 10, 2023

Should (Enhanced) version be so tolerant of opaque overlay?

Actually, @bruce-usab, on re-reading the Enhanced normative text, I do not believe that a lightbox should be considered to fail this criteria. The language does not use "obscured", it uses "hidden".

no part of the component is hidden by author-created content.

I don't think we can make the case that dimming something hides it. Even in the minimum version, we don't say the lightbox is failing Focus Not Obscured. We say it is likely to fail 2.4.11 Focus Appearance.

On rereading that part of the Minimum understanding document, I have some changes to suggest.

  1. Given that 2.4.11 is now a AAA, my feeling is that the language in the minimum should actually point to Non-text contrast, and
  2. the Enhanced version should point to Focus Appearance.

That gives us something appropriate to assess at each of the levels. If you agree, can you alter this PR to support that?

As part of that, you will need to remove this commit: 61dcd0c

At that point, the language for Enhanced seems fine for lightbox (assuming the link points to the AAA version of Focus Appearanced). The AA version would need to be updated.

@bruce-usab
Copy link
Contributor Author

bruce-usab commented May 15, 2023

@mbgower I think the root problem is that there is a bit of a disconnect between the SC name and text. because hidden is a little bit stronger than obscured. A light box certainly obscures. But does it hide?

Ping to @alastc since I think we might actually need an AGWG survey to resolve this.

Also maybe the text of Focus Not Obscured (Enhanced) AAA — and only Enhanced not (Minimum), AA — might be adjusted?

When a user interface component receives keyboard focus, no part of the component is obscured hidden by author-created content.

In `<section class="remove">` SC text for (Minimum) was used instead of (Enhanced).  Correcting a copy/paste error (that would have been caught by publication scripting, but still nice to fix).
@bruce-usab
Copy link
Contributor Author

@mbgower wrote:

That gives us something appropriate to assess at each of the levels. If you agree, can you alter this PR to support that?
....
As part of that, you will need to remove this commit: 61dcd0c

I am doing a new PR (and separate issue) for these details.

@alastc
Copy link
Contributor

alastc commented May 18, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does 2.4.12 Focus not obscured encourage a keyboard anti-pattern
3 participants