Frances' proposed response #3214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fstrr
approved these changes
May 25, 2023
detlevhfischer
approved these changes
May 25, 2023
| @@ -23,14 +24,14 @@ <h3>Setting focus to the document after dismissing a menu embedded on the page</ | |||
| <p>Activate the trigger control via the keyboard.</p> | |||
| <ul> | |||
| <li>Check whether focus is in the menu or dialog.</li> | |||
| <li>Check whether advancing the focus in the sequential navigation order puts focus in the menu or dialog.</li> | |||
| <li>Check whether moving the focus forwards once in the sequential navigation order puts focus in the menu or dialog.</li> | |||
There was a problem hiding this comment.
Thinking of dialogs with no interactive content apart from the close icon. When focus is set here on opening, it is often not easy to see since there is no other focus position to go to - in effect you can either press enter or ESC to close. In these situations the second check would not work. Not sure if this edge case (not too infrequent though) needs to be covered...
There was a problem hiding this comment.
the "check" may not necessarily be a visual check. an auditor may also just check document.activeElement.
techniques/failures/F85.html
Outdated
| <ul> | ||
| <li>Check whether focus is on the trigger control.</li> | ||
| <li>Check whether advancing the focus backwards in the sequential navigation order puts focus in the trigger control.</li> | ||
| <li>Check whether moving the focus backwards once in the sequential navigation order puts focus in the trigger control.</li> |
There was a problem hiding this comment.
"focus in" > "focus on" ?
There was a problem hiding this comment.
Can't this be said in less technical language?
alastc
commented
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #518