Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up changes to 1.4.3 and 1.4.6 understanding documents #3216

Merged
merged 1 commit into from Aug 30, 2023

Conversation

patrickhlauke
Copy link
Member

  • corrects a mistake where the text about focus/hover in 1.4.6 understanding talks about 1.4.3 applying also to focus/hover, when it actually means to say that THIS SC applies here as well. this PR now generalises that text to just say "This Success Criterion"
  • adds a <code> block that was missed out for the contrast formula
  • reformats the contrast formula rationale part for enhanced contrast, to bring it in line with the same text in the minimum contrast understanding
  • tweaks the rationale to mention 1.4.6 in relation to 7:1 ratio

* corrects a mistake where the text about focus/hover in 1.4.6 understanding talks about 1.4.3 applying also to focus/hover, when it actually means to say that THIS SC applies here as well. this PR now generalises that text to just say "This Success Criterion"
* adds a `<code>` block that was missed out for the contrast formula
* reformats the contrast formula rationale part for enhanced contrast, to bring it in line with the same text in the minimum contrast understanding
* tweaks the rationale to mention 1.4.6 in relation to 7:1 ratio
@alastc alastc merged commit cbdb5fc into main Aug 30, 2023
1 check passed
@alastc alastc deleted the patrickhlauke-pr3020-follow-up branch August 30, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants