Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in brief material for WCAG 2.0 success criteria #3219
in brief material for WCAG 2.0 success criteria #3219
Changes from 4 commits
21f46ab
4ebf8d6
d62f329
f5de52f
cfad43a
fe5966a
122fcb5
896e6bd
ee7ef18
db29bb3
1d3a9f1
dd00422
9734ce3
a00d650
b3d2739
cf98f2e
1935824
cafed04
837d245
551d842
16499bc
841ed90
97fe7a0
acf2777
ca48061
9600246
2373729
6cd61ae
4ddb242
0e2af8f
103d7cb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extend "navigate" to "navigate page sections" or "navigate different parts of a page"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the end result is easier navigation. Will think on a bit more, but every time I tried to put something like that in, it read a bit more confusingly or inaccurately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Less stilted would be "in a meaningful order"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main concern with this is that an incorrect focus order could still be meaningful; it just might be wrong!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indicator -> focus indicator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, you get that from the name of SC plus the use of "focus" 3 words before this in the same phrase. I think it's okay without it.