New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contrast-minimum.html #3240
Closed
bruce-usab
wants to merge
15
commits into
color-blind-patch
from
issue2033_patch_sc143_understanding
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
37558f3
Update contrast-minimum.html
bruce-usab e2e1bf3
Update contrast-minimum.html
bruce-usab 626fc38
Update contrast-minimum.html
bruce-usab ba1a532
Update contrast-minimum.html
bruce-usab 32fcc55
Update contrast-minimum.html
bruce-usab c302458
Update contrast-minimum.html
bruce-usab 9984d8d
Update contrast-minimum.html
bruce-usab 7015825
Update contrast-minimum.html
bruce-usab 724c11d
Update contrast-minimum.html
bruce-usab 703b590
Update contrast-minimum.html
bruce-usab f7eb439
Update contrast-minimum.html
bruce-usab b9f8cf2
Update contrast-minimum.html
bruce-usab 34916e8
Update contrast-minimum.html
bruce-usab adc7119
Update understanding/20/contrast-minimum.html
alastc 0ff8553
Update understanding/20/contrast-minimum.html
mbgower File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change does make it less clear that the minimum contrast target is understood by the working group as not solving readability for all. Was this change intended to remove the phrase "low vision" or due to concern with the word moderately? If the former, how about "... with moderately limited vision,..."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my motivation was to point to color vision deficiencies as being particularly addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern is that that describes a condition, but we're actually talking about people. And there was a prior inference in the language that the WG understood this didn't solve things for everyone.
We can solve by the addition of "more" and a couple of other words
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of the two above, I prefer the original, since this about intent. But I agree that we should not overstate the efficacy of the SC. How about:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like both new suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest: