Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understanding Focus Appearance CR3 updates #3259

Merged
merged 15 commits into from Jul 11, 2023

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Jun 30, 2023

This PR substantially overhauls the Understanding document for Focus Appearance to bring it in line with the latest Candidate Recommendation, which moved it to AAA and changed it substantially.

Preview of the understanding doc.

Overall:

  • I removed or rewrote several sections that had become obsolete, especially:
    • references to the removed adjacent contrast requirement
    • references to the "encloses or solidly bounds" text
  • I restructured the document to consolidate the remaining parts of the minimum area and encloses solidly parts into one "Minimum Area" section
    • I moved the discussion of Inline Links here as well - it seemed to fit better here than with change-of-contrast
    • I mostly rewrote the "other shapes" section to account for the updated perimeter calculation math
  • I expanded the "Relationship with Non-text Contrast" section slightly to make up for the loss of the adjacent contrast requirements in this SC itself
  • I added some new examples to the change-of-contrast section to cover discussions from the WCAG 2.x working group meeting conversations on outset vs outline vs border vs inset counting as "perimeters"
  • I audited all figures throughout the document and updated any that had become outdated/inaccurate (lots of replacing cases that previously passed with 1px thick borders to use 2px thick borders instead)
    • For cases where I needed to redo a figure that was only present as a png previously, I created an html file to act as the figure source and have included those in this PR to make it easier for future maintainers to update them.
  • I audited for any cases that were still referring to the old numbering for 2.1.11-2.1.13 and updated them accordingly

Similar to when we overhauled Target Size, I recommend reviewing this change by reading the rendered document in its totality, rather than relying on the diff in GitHub.

This PR is already huge, so I've left out of scope any updates to the corresponding non-text contrast section. I also left off for a separate PR the section I had started drafting covering dotted/dashed outlines and anti-aliasing calculations, per discussions in the WCAG 2.x backlog meetings.

Closes #3200

@alastc alastc merged commit 095491c into w3c:main Jul 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-write of Focus-Appearance at AAA
3 participants