New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.4.1 Use of Color Understanding doc: add note concerning same color case #3286
Conversation
…case closes w3c#1467 Per the feedback in the thread, the use case of a hyperlink being styled to look no different than adjacent static text would not be a failure of 1.4.1 since there is no difference in color to compare against. This PR adds a note to call that out.
broaden the intro to the note per feedback from @patrickhlauke
Co-authored-by: Patrick H. Lauke <redux@splintered.co.uk>
The change is the note circa lines 65-75. All other changes are results of formatting, and do not represent changes to content. |
Co-authored-by: Dan Bjorge <dan@dbjorge.net>
I have a few issues with the note:
I propose this paragraph instead:
P.S. Would add this as a suggestion, but the paragraph is spread across multiple lines and the GitHubb function for multi-line comments isn't accessible. |
that is the baseline assumption for any statement in the understanding documents, really. nothing is ever fully exempt from any other potential failures...so don't think it'd be necessary to explicitly call it out here. |
Great point. I'd remove the last sentence of my version entirely then:
|
incorporating/combining feedback from Shane, Detlev and Mike
Co-authored-by: Alastair Campbell <ac@alastc.com>
It was recommended to change:
⬇️ Suggested change
- prompt a response, or distinguish a visual element. For instance, a hyperlink which has been styled to appear no
+ prompt a response or distinguish a visual element, for instance, a hyperlink which has been styled to appear no
I think the original is better than the edit suggested below
I.e. I would keep the comma after response — and I would not glue the example sentence onto the end of the other sentence. I think the proposed change adds complexity and moves us in the opposite direction from plain language
… On Aug 29, 2023, at 5:30 PM, scottaohara ***@***.***> wrote:
@scottaohara commented on this pull request.
In understanding/20/use-of-color.html <#3286 (comment)>:
> @@ -63,6 +63,17 @@ <h2>Intent of Use of Color</h2>
</div>
+ <div class="note">
+
+ <p>This criterion does not apply to situations where color has <em>not</em> been used to convey information, indicate an action,
+ prompt a response, or distinguish a visual element. For instance, a hyperlink which has been styled to appear no
⬇️ Suggested change
- prompt a response, or distinguish a visual element. For instance, a hyperlink which has been styled to appear no
+ prompt a response or distinguish a visual element, for instance, a hyperlink which has been styled to appear no
—
Reply to this email directly, view it on GitHub <#3286 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACNGDXULHQVFLJCAGDAP6N3XXYDIRANCNFSM6AAAAAA2NON5TI>.
You are receiving this because you are subscribed to this thread.
|
closes #1467
Per the feedback in the thread, the use case of a hyperlink being styled to look no different than adjacent static text would not be a failure of 1.4.1 since there is no difference in color to compare against.
This PR adds a note to call that out.
Additionally this PR makes some corrections to the source code. Namely:
</meta>
and</link>
in the header - these are self-closing tags so these shouldn't be there.p
element, which is invalid and was causing the HTML parser to kick it out/created an empty paragraph after the list.