Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4.1 Use of Color Understanding doc: add note concerning same color case #3286

Merged
merged 10 commits into from Aug 30, 2023

Conversation

scottaohara
Copy link
Member

closes #1467

Per the feedback in the thread, the use case of a hyperlink being styled to look no different than adjacent static text would not be a failure of 1.4.1 since there is no difference in color to compare against.

This PR adds a note to call that out.

Additionally this PR makes some corrections to the source code. Namely:

  • removes the </meta> and </link> in the header - these are self-closing tags so these shouldn't be there.
  • fixes an instance where a list was nested in a p element, which is invalid and was causing the HTML parser to kick it out/created an empty paragraph after the list.

…case

closes w3c#1467

Per the feedback in the thread, the use case of a hyperlink being styled to look no different than adjacent static text would not be a failure of 1.4.1 since there is no difference in color to compare against.  

This PR adds a note to call that out.
broaden the intro to the note per feedback from @patrickhlauke
Co-authored-by: Patrick H. Lauke <redux@splintered.co.uk>
@mbgower
Copy link
Contributor

mbgower commented Aug 25, 2023

The change is the note circa lines 65-75. All other changes are results of formatting, and do not represent changes to content.

Co-authored-by: Dan Bjorge <dan@dbjorge.net>
@ShaneDittmar
Copy link

I have a few issues with the note:

  • I think the language should explain that this isn't a failure of this SC but might be a failure of others.
  • I don't think that "all sighted users" is the best way to identify the group of people for whom an un-styled link would be a poor experience.
  • I think it causes more problems than it solves to explicitly call this a "poor experience."
  • Editorially, there is also a sentence fragment.

I propose this paragraph instead:

This criterion does not apply to situations where color has <em>not</em>
been used to convey information, indicate an action, prompt a response, or
distinguish a visual element. For instance, a hyperlink which has been
styled to appear no different than the static text surrounding it would not
fail this success criterion, as there would be no color differentiation
between the actionable hyperlink text and the static text adjacent to it.
However, such a design might fail other success criteria or cause other
usability issues for users.

P.S. Would add this as a suggestion, but the paragraph is spread across multiple lines and the GitHubb function for multi-line comments isn't accessible.

@patrickhlauke
Copy link
Member

I think the language should explain that this isn't a failure of this SC but might be a failure of others

that is the baseline assumption for any statement in the understanding documents, really. nothing is ever fully exempt from any other potential failures...so don't think it'd be necessary to explicitly call it out here.

understanding/20/use-of-color.html Outdated Show resolved Hide resolved
understanding/20/use-of-color.html Outdated Show resolved Hide resolved
@ShaneDittmar
Copy link

I think the language should explain that this isn't a failure of this SC but might be a failure of others

that is the baseline assumption for any statement in the understanding documents, really. nothing is ever fully exempt from any other potential failures...so don't think it'd be necessary to explicitly call it out here.

Great point. I'd remove the last sentence of my version entirely then:

This criterion does not apply to situations where color has <em>not</em> been used to convey information, indicate an action, prompt a response, or distinguish a visual element. For instance, a hyperlink which has been styled to appear no different than the static text surrounding it would not fail this success criterion, as there would be no color differentiation between the actionable hyperlink text and the static text adjacent to it.

incorporating/combining feedback from Shane, Detlev and Mike
Co-authored-by: Alastair Campbell <ac@alastc.com>
@alastc alastc merged commit a9d741e into w3c:main Aug 30, 2023
1 check passed
@scottaohara scottaohara deleted the patch-3 branch August 30, 2023 12:16
@GreggVan
Copy link

GreggVan commented Aug 31, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Looking for definitive clarification regarding 1.4.1
8 participants