Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PDF techniques #3354

Merged
merged 77 commits into from Aug 30, 2023
Merged

Update PDF techniques #3354

merged 77 commits into from Aug 30, 2023

Conversation

fstrr
Copy link
Contributor

@fstrr fstrr commented Aug 22, 2023

This branch updates the PDF Techniques for the first time since approximately 2011.

  1. Reduced the amount of screen grabs
  2. Updated the screen grabs we kept
  3. Updated menu commands so that they're up to date with the current versions of apps
  4. Updated some working documents
  5. Added alt text to numerous images
  6. Fixed broken links
  7. Removed content related to Adobe LiveCycle, which was EOLd in 2013
  8. Fixed several color contrast issues in PDFs
  9. Fixed some typos
  10. Added more OpenOffice content
  11. Added support for syntax highlighting

fstrr added 30 commits March 6, 2023 18:17
-  none of the images had `alt` text; all were relying on the `figcaption` element to describe them. I fixed this.
- removed 404ing resources and updated others to https.
- removed multiple links with no text in them.
- removed an example using Word 2003. There is a Word 2007 example remaining.
Adobe’s Livecycle product doesn’t exist any more and had its last stable release 10 years ago. I removed content relating to that.
also: removed Adobe LiveCycle content as that application doesn’t exist any more.
Also: removed Adobe LiveCycle Designer content as that product no longer exists.
Also removed Livecycle content as that application is no longer being developed.
Also: removed Livecycle content
* fix incorrectly nested HTML
* fix “image” tag typo
* remove version number from Acrobat
* update screen grabs
* update working docs
@bruce-usab
Copy link
Contributor

@fstrr or @mbgower -- can you clue me into the mechanics for generating the GitHack preview for a branch or PR? Or is that exposed automatically and I am not looking in the right place?

My usual reviewing habits will be insufficient for this set of work!

@fstrr
Copy link
Contributor Author

fstrr commented Aug 23, 2023

I don't know if you can do it at a folder level, but here's the pattern for pages:

https://raw.githack.com/[account-name]/[repo-name]/[branch-name]/[folder-structure]/[file-name].html

So:

https://raw.githack.com/w3c/wcag/update-pdf-techniques/techniques/pdf/PDF1.html

Note: I added you and Mike as reviewers yesterday, but then found out that @ljoakley has one more file (PDF21) to work on, so I changed the PR back to a draft. That said, there's plenty of files before that to review before you get to that one.

@bruce-usab
Copy link
Contributor

I added you and Mike as reviewers yesterday

Which is why I asked! No need to preview the whole folder, so thanks very much for the GitHack syntax. This is a lot of work your are doing!

Ping to @DuffJohnson in case he is curious to see where we hope PDFA might pick up.

@fstrr
Copy link
Contributor Author

fstrr commented Aug 23, 2023

I do wish that we'd also updated these to be tool agnostic rather than updating vendors' products. Maybe when the forthcoming PDF Association documents get published it'll be a sensible time to re-visit the techniques.

@DuffJohnson
Copy link

Thanks for the pointer; I've forwarded this to the PDF Accessibility LWG for review.

@fstrr fstrr marked this pull request as ready for review August 24, 2023 15:36
@fstrr fstrr requested a review from bruce-usab August 24, 2023 15:36
@fstrr
Copy link
Contributor Author

fstrr commented Aug 24, 2023

@bruce-usab It's all done, so I've changed it to ready for review and assigned you.

@mbgower
Copy link
Contributor

mbgower commented Aug 25, 2023

@awkawk FYI some updates to the PDF techniques. Willing to review? :)

@awkawk
Copy link
Member

awkawk commented Aug 25, 2023

@mbgower arranged for Rob on my team to do so

@awkawk
Copy link
Member

awkawk commented Aug 25, 2023

One note that jumps out is that Livecycle Designer wasn't EOL'd, it was renamed to Adobe AEM Designer. We can get an updated screenshot but the dialog is basically the same. See https://help.adobe.com/en_US/AEMForms/6.1/DesignerHelp/WS92d06802c76abadbe98a8d5129b8b01f08-7fd8.2.html for a reference.

@alastc alastc merged commit 3e2df75 into main Aug 30, 2023
1 check passed
@alastc
Copy link
Contributor

alastc commented Aug 30, 2023

We agreed to merge these, but can take updates if Rob finds anything wrong.

@alastc alastc deleted the update-pdf-techniques branch August 30, 2023 11:22
@awkawk
Copy link
Member

awkawk commented Aug 30, 2023

That's fine. For the future, if planning to approve a set of changes to 23 techniques on Tuesday, asking for review 4 days earlier (and over a weekend) is a little tight.

Also note that the comment that I made 5 days ago was not attended to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants